Comments (17)
There are so many ways you can fix this! Stop saying you can't when you clearly can!
Especially as the exception happens midway through the application.
METHOD 1 - Try Catch
The error is an unhandled exception because something doesn't exist, just try catch stuff and check what error is given, if its that it couldn't load a type, then tell me to update .NET.
Remember the types get loaded before the method that executes them.
METHOD 2 - Check for InteropServices.OSPlatform dynamically
Read from the assembly containing InteropServices and see if this type exists, if it doesn't tell me to update .NET.
METHOD 3 - Wrapper EXE
Make another executable that loads an EnhancedDiscord DLL dynamically and runs that and checks .NET version and InteropServices beforehand.
METHOD 4 - Check .NET Version on startup
Title really.
I've given you several methods here on how to fix it. So go do that.
from enhanceddiscord.
Enjoy your broken application. 🙃
from enhanceddiscord.
Well it says that in the readme and we don't have direct control over the .net errors
from enhanceddiscord.
You do. You can just try catch it or load dynamically and realize its wrong and then tell me to install latest .NET. 🙃
from enhanceddiscord.
Nope that's not the current loading schema, it is a hard dependency.
from enhanceddiscord.
No need to be rude, and all of those would change our loading schema, so I have no intention of rewriting the installer to do it. It says the necessary dependency on the readme. This isn't even my project.
from enhanceddiscord.
Works fine, thanks.
from enhanceddiscord.
Works fine, thanks.
"It's a feature, not a bug!"
from enhanceddiscord.
Don't recall using the term feature, but alright. Pull requests are always welcome if you find this such a dire bug.
from enhanceddiscord.
@TedsterTech @Joshua-Ashton
from enhanceddiscord.
As you said
This isn't even my project.
from enhanceddiscord.
And as you so politely said:
So go do that.
from enhanceddiscord.
If that is not your project , why did you reply like that in the first place?
"we don't have direct control over the .net errors"
from enhanceddiscord.
I'm a contributor and I'm aware of the time limitations of both myself and the ED creator. At this time, solving this issue (that occurs seldomly and is explained in the readme) is not within our current effort's scope. The way that the installer is currently written we don't control the loading process of the .NET dependency (or try catch every usage), that would take implementation changes.
I'm not denying this is an error or calling it a feature as was facetiously suggested, I'm saying that it's a rare error we are not focusing our efforts on. The application itself (ED) is functioning fine and the fix for the installer is explained in the readme for the few encountering the error.
from enhanceddiscord.
You can easily do 1 big try catch around it or another method I described. This wouldn't take you a lot of time. You objectively do have complete control over this and can use every method I suggested. 🤠
from enhanceddiscord.
In fact, for the try catch you'd only need to do it upon the first use of a InteropServices (try catch the first function that uses it) and then just show me an error dialog saying what I have to do there.
from enhanceddiscord.
The code does not currently do that, I think I mentioned that so while it is possible, it doesn't currently control the error flow. I think that was a communication error, as I'm referring to the current code and you seem to be directing it to me:
we don't have direct control over the .net errors
This was meant as we don't have anything in the code handling the errors, as in no controls in place. That's why I followed up by saying that isn't the current loading schema. The only thing we currently have is the note on the readme for the few people that have the error.
Unfortunately, it would take more time than you might think to complete the entire process as the installer would need to be recompiled by the repo owner, after a PR, in order to upload it to the website. The version on the website is actually out of date compared to what is on the repo because he is currently quite busy with other things. Also as I said before, PRs are always welcome. Feel free to use any of the methods you pointed out above, I personally would go with number 4 for better UX than number 1.
Have a nice night!
from enhanceddiscord.
Related Issues (20)
- Character count (beta) needs to be rewritten
- Colorblindness accessibility issue in theme_v2.css included from default style.css HOT 1
- Tag All needs to be rewritten
- All channels are shown in the channel list. HOT 1
- TypeError: Cannot read property 'contextMenu' of null HOT 2
- When visiting an nsfw hidden channel, and the user hits confirm. The client will still try to load the channel messages instead of just showing a warning HOT 2
- Client still tries to load hidden channel if it was the last selected channel
- EnhancedDiscord no longer works on latest Discord version HOT 6
- Doesn't work with the latest version of discord, in Linux. HOT 11
- Unable to change ED settings from the settings page
- Can't watch streams on Linux HOT 1
- Please allow us to enable win32 themes HOT 3
- Improper Electron Security Practices HOT 3
- Site is down HOT 3
- BetterDiscord plug-ins not working due to recent changes HOT 8
- Can't go into settings on ED HOT 3
- Hidden Channels aren't working HOT 1
- Discord crashes upon using SHIFT+ENTER shortcut. HOT 12
- Discord 0.0.309 will immediately crashed after pasting url HOT 2
- Archive the repo so no more Issues and PR can be made, and close existing ones HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from enhanceddiscord.