GithubHelp home page GithubHelp logo

Comments (16)

stevepolitodesign avatar stevepolitodesign commented on July 27, 2024 2

Pundit is one of those gems that I reach for with every Rails project. It can even be used to create feature flags, but clearly I'm biased 🤣

from railsdevs.com.

stevepolitodesign avatar stevepolitodesign commented on July 27, 2024 2

@Tonksthebear as @joemasilotti mentioned, I recommend you branch off of #13. That way you'll have everything you need to create a DeveloperPolicy with Pundit. I recommend running rails g pundit:policy developer since it will create the appropriate file.

from railsdevs.com.

Tonksthebear avatar Tonksthebear commented on July 27, 2024 2

Thanks for the suggestion @stevepolitodesign

Unless I'm missing something, there isn't much room to progress #13 until users are actually in. I know #7 seems to be sorting out to go about managing Users and Accounts.

It seems like I should hold off on moving forward until someone actually implements Devise so that I can reference the current_user

from railsdevs.com.

joemasilotti avatar joemasilotti commented on July 27, 2024 1

I'd just double check with @stevepolitodesign and @Tonksthebear because they commented earlier. Other than that, anyone can work on anything and I'll make sure to review all PRs.

from railsdevs.com.

Tonksthebear avatar Tonksthebear commented on July 27, 2024 1

Sounds good 👍 happy to take it over

from railsdevs.com.

stevepolitodesign avatar stevepolitodesign commented on July 27, 2024

I strongly recommend we adopt some kind of authorization system (like pundit) to help build this and future features.

This will help keep authorization logic consistent and reliable.

from railsdevs.com.

joemasilotti avatar joemasilotti commented on July 27, 2024

I've never used pundit, but it looks promising. If it ends up being less code to manage then I'm all for it.

from railsdevs.com.

Tonksthebear avatar Tonksthebear commented on July 27, 2024

I've historically used cancancan. I'm not trying to advocate it's better, just wondering if you know what the benefits of using pundit are instead of something like cancancan?

from railsdevs.com.

ashawareb avatar ashawareb commented on July 27, 2024

Hey @joemasilotti
I can work on this one if it's not assigned to anyone yet

from railsdevs.com.

Tonksthebear avatar Tonksthebear commented on July 27, 2024

I'd just double check with @stevepolitodesign and @Tonksthebear because they commented earlier. Other than that, anyone can work on anything and I'll make sure to review all PRs.

I'm happy to get an update out, but I'd do it with cancancan. So whatever direction you want to take! I'm happy to get a PR in if you choose cancancan, but @stevepolitodesign should take it if you want to use pundit

from railsdevs.com.

joemasilotti avatar joemasilotti commented on July 27, 2024

pundit is my vote for now!

from railsdevs.com.

stevepolitodesign avatar stevepolitodesign commented on July 27, 2024

@joemasilotti I created a PR #13 that installs Pundit. Once merged, someone, can take over this issue 👍

from railsdevs.com.

joemasilotti avatar joemasilotti commented on July 27, 2024

Thanks @stevepolitodesign! @Tonksthebear, I recommend you work off of @stevepolitodesign's PR #13.

from railsdevs.com.

joemasilotti avatar joemasilotti commented on July 27, 2024

Sounds great, @Tonksthebear! One more heads up, there's another issue, #7, that might be blocking this. Make sure to check in there so no effort is duplicated. :)

from railsdevs.com.

joemasilotti avatar joemasilotti commented on July 27, 2024

FYI, #7 is done with basic users and authentication.

from railsdevs.com.

Tonksthebear avatar Tonksthebear commented on July 27, 2024

Awesome! I'll knock that out ASAP

from railsdevs.com.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.