Comments (16)
Pundit is one of those gems that I reach for with every Rails project. It can even be used to create feature flags, but clearly I'm biased 🤣
from railsdevs.com.
@Tonksthebear as @joemasilotti mentioned, I recommend you branch off of #13. That way you'll have everything you need to create a DeveloperPolicy
with Pundit. I recommend running rails g pundit:policy developer
since it will create the appropriate file.
from railsdevs.com.
Thanks for the suggestion @stevepolitodesign
Unless I'm missing something, there isn't much room to progress #13 until users are actually in. I know #7 seems to be sorting out to go about managing Users and Accounts.
It seems like I should hold off on moving forward until someone actually implements Devise so that I can reference the current_user
from railsdevs.com.
I'd just double check with @stevepolitodesign and @Tonksthebear because they commented earlier. Other than that, anyone can work on anything and I'll make sure to review all PRs.
from railsdevs.com.
Sounds good 👍 happy to take it over
from railsdevs.com.
I strongly recommend we adopt some kind of authorization system (like pundit) to help build this and future features.
This will help keep authorization logic consistent and reliable.
from railsdevs.com.
I've never used pundit, but it looks promising. If it ends up being less code to manage then I'm all for it.
from railsdevs.com.
I've historically used cancancan. I'm not trying to advocate it's better, just wondering if you know what the benefits of using pundit are instead of something like cancancan?
from railsdevs.com.
Hey @joemasilotti
I can work on this one if it's not assigned to anyone yet
from railsdevs.com.
I'd just double check with @stevepolitodesign and @Tonksthebear because they commented earlier. Other than that, anyone can work on anything and I'll make sure to review all PRs.
I'm happy to get an update out, but I'd do it with cancancan. So whatever direction you want to take! I'm happy to get a PR in if you choose cancancan, but @stevepolitodesign should take it if you want to use pundit
from railsdevs.com.
pundit is my vote for now!
from railsdevs.com.
@joemasilotti I created a PR #13 that installs Pundit. Once merged, someone, can take over this issue 👍
from railsdevs.com.
Thanks @stevepolitodesign! @Tonksthebear, I recommend you work off of @stevepolitodesign's PR #13.
from railsdevs.com.
Sounds great, @Tonksthebear! One more heads up, there's another issue, #7, that might be blocking this. Make sure to check in there so no effort is duplicated. :)
from railsdevs.com.
FYI, #7 is done with basic users and authentication.
from railsdevs.com.
Awesome! I'll knock that out ASAP
from railsdevs.com.
Related Issues (20)
- Progressively enhanced combobox for developer specialties HOT 5
- Fresh database reset and migration breaks seeds HOT 4
- Refactor Hired::Form into Developers::CelebrationPackageRequest HOT 1
- Schedule a call link HOT 4
- Research calendar links and scheduling UX HOT 4
- Extend an (unofficial) offer HOT 13
- Convert hiring agreement to in-app DocuSign HOT 8
- Notify Admin by tracking user's LinkedIn profile on its any experience changes. HOT 5
- Rework "stale" developers HOT 10
- Rework "Recently Active" badge HOT 5
- Fix duplicated protocol prefix in input fields HOT 2
- Account vs. User (take 2) HOT 6
- Rename form param key for Admin::Businesses::HiringInvoiceRequestNotification
- Error message when address is missing in `/developers/new` form is confusing. HOT 6
- Upgrade Rails version HOT 2
- Fixing Selenium::WebDriver::Error::UnknownError HOT 2
- Update Bundler version HOT 1
- New payment processor HOT 1
- Mail not being sent in conversations HOT 2
- 'Share link' Stimulus error on Firefox (Desktop) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from railsdevs.com.