Comments (15)
If the API supports it, which it does, should be about 1/2 day to add it. Most of the boilerplate code for communicating with the Github API is the same. Here's how I fetch a markdown file:
https://github.com/joemccann/dillinger/blob/master/app.js#L358-400
The clientside wiring is super modular too:
https://github.com/joemccann/dillinger/blob/master/public/js/dillinger.js#L1331-1372
Pull requests gladly accepted!
from dillinger.
I probably won't do it since I'm not using Dillinger or creating lots of Gists (I'm using Vim to edit my mdown files..). I added the feature request since I saw the twits from @LeaVerou and I'm not sure if she realized that the project was open source and to let you know that some people would like this feature. cheers.
from dillinger.
Hey no worries! I really appreciate you taking the time to aggregate the tweets into a feature request. I'll probably just build it myself, but always open to other contributors. Thanks!
from dillinger.
Joe, I've worked on the Gist API for dabblet, so its code or UX patterns might help: https://github.com/LeaVerou/dabblet
from dillinger.
@LeaVerou thanks, will have a look. @github's API is a thing of beauty so it should be straightforward.
from dillinger.
+1
Not a js expert, but will give this a go when the weather becomes a little worse.
from dillinger.
@tasuk that'd be great. thanks!
from dillinger.
What blocked this? Anything in particular or did it just never end up happening?
from dillinger.
No one implemented it.
from dillinger.
I would like to, I have some experience with javascript. jquery. perhaps we could start off with a simple task?
from dillinger.
Hey @joemccann, I'd like to take a look at this. I think it'll be easier if gists were separate from repositories meaning you'll have a "save to github" as well as a "save to gist" option in the menu. Authentication can be different as well as gists are a separate scope, or we can authenticate both together.
What do you think?
from dillinger.
Totally open to adding gist support but it needs to be another plugin,
meaning, app code, UI code, interaction design, etc. all needs to be hashed
out. I'm all for adding it if it adheres to current Dillinger approach
On Sun, Nov 1, 2015 at 12:10 AM, Oded Welgreen [email protected]
wrote:
Hey @joemccann https://github.com/joemccann, I'd like to take a look at
this. I think it'll be easier if gists were separate from repositories
meaning you'll have a "save to github" as well as a "save to gist" option
in the menu. Authentication can be different as well as gists are a
separate scope, or we can authenticate both togetheer.What do you think?
—
Reply to this email directly or view it on GitHub
#8 (comment).
from dillinger.
I agree that the UI code should be separate, but why should it be a separate plugin? don't you think it'll be easier to add functionality to the existing GitHub plugin? there's probably a lot of code there that we can reuse no?
from dillinger.
I suppose we could extend the github plugin code but it may make sense to
unbundle the github plugin itself to have GH-repos an GH-gists or something
along those lines. Make sense? Gists and repos APIs have their own version
on GH so bundling them under one repo concerns me
On Mon, Nov 2, 2015 at 12:21 PM, Oded Welgreen [email protected]
wrote:
I agree that the UI code should be separate, but why should it be a
separate plugin? don't you think it'll be easier to add functionality to
the existing GitHub plugin? there's probably a lot of code there that we
can reuse no?—
Reply to this email directly or view it on GitHub
#8 (comment).
from dillinger.
Makes sense. I'll try to get into it and let you know how it goes.
from dillinger.
Related Issues (20)
- Open a URL? HOT 2
- dillinger.io not updated to latest HOT 1
- Website down ? HOT 2
- Image not present when exported to PDF HOT 3
- Error on npm i HOT 2
- Graceful way to upgrade dependencies HOT 2
- Doesn't scroll with up/down arrow keys
- Documentation/Installation Issues: Node Version HOT 3
- [bug] Zen Mode - autosave doesn't work
- Build status? Travis CI link goes 404
- Is this repo still maintained? README vastly out of date (not even node 16 supported) HOT 4
- Dillinger fails to understand expression inside LaTeX environment
- File size issue
- Use Chrome Extension to manipulate the markdown HOT 1
- Using unicode format codepoint Word Joiner is buggy
- OneDrive Import -> "This API is no longer supported"
- Dropbox plugin secretkey error
- Ordered list items with parentheses don't expand in PDF export HOT 1
- Bug: Unable to import locale file (binary file)
- Feature: "Import from" any remote git repo (Forgejo, Gitea, GitLab)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dillinger.