[object Object].removeClassFromAllLines is deprecated. about atom-jshint

[vogonistic]

👍

[Joezo]

Thanks for bringing this up, when I get a bit of time i'll do this

[briannhinton]

Great. Thanks for the reply. That exclamation mark is annoying :)

[framerate]

I started a fix for this but didn't complete it. Some info on how to do it here:

https://discuss.atom.io/t/how-to-highlight-line-or-region-from-package/9871/25

[framerate]

I've finished a rough conversion using decorations:

https://github.com/framerate/atom-jshint

@Joezo - let me know your thoughts and if I should do a PR. It was super fast and my first atom plugin project, but I want to help get this fixed.

Pretty much only changed this function: https://github.com/framerate/atom-jshint/blob/master/lib/atom-jshint.js#L172

edit: This rough version just highlights the lines red. Someone can maybe take it from there and make it pretty!

edit again: This isn't done, but hoping to get the ball rolling!

[Joezo]

Thanks for looking at it, i'll take a look soon, just a little busy at the second :)

[Joezo]

@framerate if you could submit that as a pull request that'd be great!

[framerate]

@Joezo - Done! I recommend someone else taking a look at it before deploying though! I worry that the loop/remove decorators isn't efficient?

[Joezo]

All deprecations are fixed in branch fix-deprecations, this will be published soon. Thanks for reporting the issue :)