Comments (3)
johanberntsson
commented on July 17, 2024
No place seems to use the return value, so the if-statement seems redundant, but is it wrong? Can you give me an example of where using _GrabIfNotHeld seems to go wrong. What is there to fix?
from punyinform.
hlabrand
commented on July 17, 2024
No it's not a bug, it's just that you're returning a value and then recomputing it. It could be "if (_GrabIfNotHeld(noun)) rtrue;" instead
from punyinform.
johanberntsson
commented on July 17, 2024
Yeah, make sense. I've added unit tests and changed the logic as you suggested.
from punyinform.
Related Issues (20)
- The sentence construction differs for MSG_SEARCH_IN_IT_ISARE and MSG_SEARCH_ON_IT_ISARE HOT 1
- Wrong message for 'take off' an unworn clothing object HOT 1
- The strict mode indicator is missing HOT 1
- Grammar of verb 'enter' without noun HOT 1
- Punctuation mark only HOT 1
- Catching AskTo differs from the standard library HOT 3
- Naming the library to make it clear this is not an official release. HOT 1
- Enterable object movement HOT 4
- Additional newline after tall inventory output HOT 3
- Auto-guess noun improvements HOT 1
- Global created before Global.h causes crash in z3 HOT 1
- Document how to generate playable HTML HOT 1
- Inform 6.43 problems HOT 7
- Latest is tagged as 3.2, but identifies itself as 3.1 HOT 1
- Replacement of dictionary words with available constants HOT 1
- Inappropriate message for the Enter action if the preposition is missing HOT 1
- The title of the help menu is not centered in the window HOT 2
- Searching on a supporter object missing from the grammar HOT 1
- Reversed definition of MSG_THROW_ANIMATE and MSG_THROW_DEFAULT constants HOT 2
- A container object with a single scenery or concealed object inside does not display its empty state HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from punyinform.