Comments (5)
same here, commenting out that line:
// if (!(keys != null && keys.includes(keyCode)) && !['ctrl', 'control', 'unknown', 'meta', 'alt', 'shift', 'os'].includes(keyCode)) {
// console.log("elmoo");
// return false;
// }
in isHotkeyMatchingKeyboardEvent()
fix the issue, if that helps
happens is firefox / chrome - linux and macos
I've managed to log that before this condition execute, and I'm not sure why "right" is in keys, maybe some memoization issue 🤷🏻
{"pressedKey":"delete","keyCode":"","keys":["right"]}
downgrading to 4.4.1 fixed the issue, all good 👍🏻
from react-hotkeys-hook.
Hmh, weird. I'll have a look into it.
from react-hotkeys-hook.
Weirdly enough only Shift+?
works for me, the other two don't register.
from react-hotkeys-hook.
Fixed in 4.4.4
from react-hotkeys-hook.
Thank you for looking into this.
After updating the CodeSandbox to 4.4.4
: shift+?
and shift+minus
now both work, but shift+plus
still doesn't.
Note also that on a extended keyboard with separate numpad, neither shift+plus
nor shift+minus
work.
from react-hotkeys-hook.
Related Issues (20)
- [BUG] Ctrl + Alt + alphabetic key shortcut won't work on Firefox on some international layouts
- [BUG] All components that use `useHotkeysContext()` is re-rendered when scopes change HOT 2
- Call ignoreEventWhen only if KeyboardEvent matches a hotkey HOT 2
- [BUG] isHotkeyPressed does not recognize arrow keys (ex: "ArrowLeft"), but useHotkeys does
- `useHotkeysContext` is missing in docs HOT 2
- [BUG] 4.4.2 missing dist HOT 1
- [BUG] Pressing modifier keys while other keys is held triggers other key, and prevents other keys HOT 3
- [BUG] Attaching resulting ref to a different element stops the shortcuts/hotkeys from working HOT 6
- [BUG] `option` Key No Longer Registers in v4? HOT 2
- [BUG] cannot trigger hot key when pressing "," (comma). HOT 1
- slash, backslash, and bracketright are not defined correctly in parseHotkeys.ts HOT 9
- [BUG] meta on Mac does not capture cmd like the docs say HOT 3
- What is v4.5.0? HOT 1
- [BUG] Working locally, but not in production HOT 6
- [BUG]The keyboard combination doesn't work in focused input HOT 2
- [PSA] You probably want `equal` instead of `+` (plus/bracketright) HOT 1
- The useRecordHotkeys hook should allow us to programatically set the keys HOT 1
- [BUG] Does not handle the 'Alt Graph' modifier key HOT 1
- Match a key pressed by character (optionally maybe) instead of keyCode HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-hotkeys-hook.