Comments (4)
Found the issue (pull request). When flipping the pixels to fix orientations 5
and 7
, the destination width
and height
were wrong. That's why the destination image was broken.
The fix has been pushed in [email protected]
.
Let's close this. Please feel free to reopen if you still have issues. Thanks again for the report!
from jpeg-autorotate.
@johansatge any idea what is going on? I need fix for this asap and are willing to fix the source code my self if you give me some pointers where to start 👍
from jpeg-autorotate.
quick workaround with sharp library if anyone needs it
if (orientation > 1) {
if (orientation === 5 || orientation === 7) {
// Until auto-rotate is fixed
if (orientation === 5) {
sharp(filePath).rotate(-90).flip().toBuffer().then( data => {
fs.writeFileSync(filePath, data);
}).catch( err => {
Helper.returnError(res, err, 400, `api_v1_photo:get/${req.params.orderId}/${req.params.photoId}`);
});
} else {
sharp(filePath).rotate(90).flip().toBuffer().then( data => {
fs.writeFileSync(filePath, data);
}).catch( err => {
Helper.returnError(res, err, 400, `api_v1_photo:get/${req.params.orderId}/${req.params.photoId}`);
});
}
} else {
fs.writeFileSync(filePath, buffer);
}
}
from jpeg-autorotate.
Hi,
thanks a lot for reporting this.
I reproduce too with the images from the /test/samples
directory. It looks like the issue has been here for some time, unfortunately.
I had a quick look in src/transform.js
and didn't see what's wrong. I will analyze the issue deeper in the next days. Before next week hopefully.
Note, this issue demonstrates that the existing tests are clearly not covering this module's features correctly. I have opened #12 to try to address this.
from jpeg-autorotate.
Related Issues (16)
- Npm Run Build fails to minify package HOT 2
- Visual testing HOT 1
- cli has no affect? HOT 2
- How to pass Buffer as argument instead of path? How to solve following error? HOT 3
- Wildcard support not working correctly in cli HOT 1
- Glob as CLI path HOT 2
- is quality 100 the same as lossless? HOT 2
- Ability to increase the maxMemoryUsageInMB option in jpeg-autorotate HOT 3
- EACCES: permission denied HOT 2
- CLI unusable due to "colors" module debacle HOT 2
- How to use this for image which is being fetched from online source, I am not looking for saving the file on disk before rotating. HOT 1
- Keep Exif data HOT 1
- Does it work in the browser? HOT 4
- Thank you HOT 1
- Not compatible with node 10 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jpeg-autorotate.