Comments (3)
I know how annoying this is, but this really isn't a problem with Extended CPTs and should be fixed in the plugins that are not returning an array from this filter. If a plugin can't trust other plugins to return the correct type from a filter then all hope is lost and every callback for every filter should perform a type safety check as a guard condition.
Do you know which plugins are affected? I'm happy to speak with the authors and advise on corrective measures.
from extended-cpts.
Well in our issues we saw developers and plugins so I report when I found it, the problem is when they get a fatal error and blame us...
It is not possible to do a function that wrap the filter and check the input?
This issues are blocking us to use the library in premium plugins and not just on custom plugins where I know the environment plugin.
I want to avoid people that creates tickets or reach us on every social or email just to report a fatal error (because happens in those cases) on upgrading our plugin because I switched to the main repo.
from extended-cpts.
Right, but this is papering over the issue instead of addressing the root cause, which is a bug in some code elsewhere.
This happened a few times with my User Switching plugin (which also uses type hinted parameters for filter callbacks) and it ultimately helped two users discover a security vulnerability in other plugins that were returning null from user capability filters. The PHP warnings had gone ignored.
Like I said, I'm happy to take a look at any plugins or themes that return an invalid type from this filter and help them fix it, but fixing this in Extended CPTs isn't the right place.
from extended-cpts.
Related Issues (20)
- Problem with use meta in WP_QUERY HOT 2
- Plugin is incompatible with Composer 2 HOT 1
- Consider using a different method to check a date/time type value HOT 2
- Taxonomy admin cols meta_key date_format HOT 1
- Shared post_tag between CPT's and admin fillter tag=0 issue?
- Fatal Error after migrating from production to staging environment HOT 3
- Will this eventually be useable in a plugin? HOT 1
- Admin Filter, not filling in select value with array key HOT 1
- wp-browser composer patch is no longer valid when running `composer install`
- String value for "has_archive" not respected HOT 1
- filter by taxonomy when setup admin_filters key HOT 4
- ACF date field not formatting correctly in admin column HOT 8
- Sorting not working on single tem page HOT 1
- Setting 'meta_box' => 'radio' causes unusual behaviour
- Register fields with WP GraphQL HOT 2
- Conflict with Permitpress Pro, proposed solution HOT 1
- Package License "GPL-2.0+" is a deprecated HOT 1
- WordPress 6.3 support
- should Admin columns work in a default post type like page? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from extended-cpts.