Feature: Divider Line Support about vue-simple-context-menu

[johndatserakis]

Sure, I think that'd be a great addition. I think we could add a type property, and display a divider when the value divider is passed.

I'll try to get to this in the next week or so. Thank you.

[mikeerickson]

Great, let me know if you need any assistance.

[johndatserakis]

Ok great - this is now out in v3.3.0 from this pr: #28.

[mikeerickson]

@johndatserakis Hey there, I see this was added, just got around to implementing and have a display issue I wanted you to review.

I am curious if there is something else I need (updated css?)

[johndatserakis]

Hey Mike,

Strange - yea the new css should just come when you upgraded your library.

The live demo site is showing the divider without issue:

Hmm, I wonder what the issue could be. I just checked on Chrome, Safari, and Firefox all on a Mac and it was fine. What browser and computer are you looking on?

There is a little bit of a "dance" that I had to do to get the padding and height of the divider to play nice - but I'm not seeing any negative effects of that.

Are you adding any custom css that's overwriting the .vue-simple-context-menu__divider CSS by any chance? That could do it - like if you're overwriting the padding in total.

If you can provide a codepen or something demonstrating this I'd be more than happy to take a look and fix it.

Sorry for the issue.

[mikeerickson]

Hey John

I tried to make a codepen, but I always receive an error about the missing required parameter elementId (which I am definitely supplying).

Here is a codepen that I started Codedungeon vue-context-menu codepen

I have also created a quick Vue app (using vue cli) which can be found here:

vue-simple-context-menu-test

The repo shows the problem

[johndatserakis]

Thank you @mikeerickson for the example - that was perfect and helped me find the problem right away. There was an issue with the box-sizing setting on the divider. I fixed it here: #33. I am putting out a new version now at v3.3.2.

Thank you for your help on this! Sorry about the issue.

[mikeerickson]

Awesome, glad it helped and you were able to cure. I will be deploying on Monday 👍