GithubHelp home page GithubHelp logo

Comments (2)

johndoh avatar johndoh commented on July 18, 2024

I think this is related to roundcube/roundcubemail#6145. The contextmenu plugin enables commands when its opened and then returns them to their original state so as not to mess up the main UI.

The move and copy functions are unique in that they have a 2 stage execution and the actual command execution isn't until stage 2 which is after contextmenu is closed. The state of an command is checked before any JS events are triggered so I think the solution can only be found inside app.js

I'm not sure what is best though as its really only useful for plugins rather than anything in the core. The command could be temp enabled like it is inside contextmenu:

       uids = this.env.uid ? [this.env.uid] : this.message_list.get_selection();
-      return this.folder_selector(event, function(folder) {
-        ref.move_messages(folder, null, uids);
+      return this.folder_selector(event, function(folder, obj) {
+        var prev_command = ref.commands['move'];
+        rcmail.enable_command('move', true);
+        ref.command('move', {id: folder, uids: uids}, obj, event);
+        rcmail.enable_command('move', prev_command);
       });

Or may be something added to rcmail.command() to make it pass the enabled check.

from roundcube-contextmenu.

alecpl avatar alecpl commented on July 18, 2024

Fixed with roundcube/roundcubemail@cb8c07843bd63f4c98. Thanks.

from roundcube-contextmenu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.