Comments (1)
Ideally it should be displayed in the margins to avoid obstructing the text.
Another issue is that it probably needs to be aware of the visible viewport so that in paginated mode, highlights that span multiple pages would have the icon on all pages. Edit: on second thought, maybe it'd be enough to show it at either the start or end of the highlight; showing it on each page is a bit weird as it would seem like there are multiple notes for the highlight.
So considering these two points, I think it'd probably make sense to have the renderer export a list of rects for the pages. Then it should be relatively straight forward to calculate the desired positions for the icons.
There are a couple remaining issues with this. The first is whether or how to handle collisions when you have multiple highlights on the same line. The second is whether or how to handle pointer events. Currently events are only handled if you click inside the rects of the highlighted text, rather than the hightlights themselves.
from foliate.
Related Issues (20)
- Page swipe does nothing in RTL manga HOT 1
- Suggestion on making a real favorite reading list HOT 1
- Book titles and button icons don't render correctly when in grid view
- No keyboard shortcuts for searching through books library
- Keyboard shortcut for toggling / pinning sidebars does not work when sidebar is not focused/shown HOT 1
- Inside a book, `Ctrl+F` search keyboard shortcut does not work if the book pages are focused instead of the sidebar HOT 1
- Text is cutoff at bottom HOT 2
- font - smoothing HOT 1
- [Bug Report] Unable to open a pdf file
- Non-obvious way to bookmark a page. HOT 6
- "Trasnslate" popup does not close upon selecting any language HOT 1
- Using Festival TTS with v3.1.1 HOT 2
- Foliate hangs when loading file on Kubunti 24.04 HOT 1
- List keyboard shortcuts HOT 2
- Synchronize page turn with text-to-speech HOT 1
- cant open a any epub HOT 1
- syntax highlighting of code blocks only works for default theme HOT 3
- Offset value for pagination HOT 1
- Is it possible to remove the border? HOT 3
- Option to watch folders
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from foliate.