Comments (1)
OK, this was still #7. I thought I had fixed it, but while I reloaded the plugin, the plugin imports game.py, which doesn't reload because reload() isn't called on it and it's cached in sys.modules
. I fixed this in a097afa by moving all of game.py into plugin.py, which I don't particularly like.
Looking at supybot plugins, it looks like they force the plugin to call reload()
on any of its imports. This works well for second-order imports though it does mean plugin authors need to be aware of this limitation.
Another solution would be to somehow modify sys.modules
to cause it to do a fresh load on all imports, but this probably has lots of dangerous side effects. In any case, that would need to be done inside Cardinal's core.
For now, I'm going to use the reload()
trick.
from cardinal-cah.
Related Issues (20)
- When asking a player to pick a white card, send who is judging in the PM HOT 1
- Pick 3's should draw 2 cards for all players before asking them to pick 3
- "Wait your turn please." is sent to channel rather than PM
- If all players leave the game while it is starting, end the game
- Add support for mixing and matching decks
- Add minimum/maximum game points HOT 1
- Allow halfops and above to kill games in progress
- Track stats across games & send with score
- Allow players to join during the first round or two
- Don't allow non-players to start the game with .ready
- Show the score every 2-3 rounds
- Question (black card) doesn't make sense
- Add a command to print the current score
- Second choice in pick 2s not consistently taken? HOT 1
- Make a haiku only takes 1 choice
- What's the next superhero/sidekick duo? only takes 1 card
- ___ + ___ = ___ fails to notify channel when people have picked HOT 3
- During ___ + ___= ___, Cardinal did not notify the channel when players had picked HOT 1
- Allow choosing the number of points the game should be played to
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cardinal-cah.