Comments (6)
Which URL on wordpress.com? On https://wordpress.com/?
from library-detector-for-chrome.
Yeah, the home page... but only w/ mobile emulation enabled in devtools.
from library-detector-for-chrome.
On desktop, if not logged-in to WordPress.com, I see:
<meta name="generator" content="WordPress.com">
I see the same when emulating as Chrome Android Mobile.
(When I'm logged into WordPress.com I'm redirected to the admin backend of a site I manage there.)
When I look at an actual blog hosted on WordPress.com, like vintageportland.wordpress.com, I see the same generator tag. I'm actually a bit surprised that "WordPress.com" is the generator rather than the normal "WordPress". Nevertheless, both would seem to work fine according to the current library detection logic:
Library-Detector-for-Chrome/library/libraries.js
Lines 1674 to 1676 in 3135bb2
When I run that logic in DevTools, it is resulting with a version
being "WordPress.com"
.
So that would seem to be working correctly?
from library-detector-for-chrome.
Perhaps there is an A/B test? For me, on desktop hasWPIncludes
is true (the other is false); but under mobile emulation hasWPIncludes
is false. There is no wlwmanifest
file for the mobile load (<link rel="wlwmanifest" type="application/wlwmanifest+xml" href="//s1.wp.com/wp-includes/wlwmanifest.xml">
)
from library-detector-for-chrome.
Oh, I passed over those parts of the test
:
Library-Detector-for-Chrome/library/libraries.js
Lines 1669 to 1672 in 3135bb2
I'm somewhat surprised those conditions are part of the test
. Someone can turn off the WordPress API, and thus hasAPILinkElem
would be false
. Similarly, a theme doesn't necessarily include any scripts or stylesheets that load from wp-includes
(especially if an optimization plugin is processing them).
Also, it turns out that the wlwmanifest.xml
link is deprecated as of 6.3.0 (the next stable release) and will be removed from WordPress core. So it is expected that this wouldn't show up in the future:
<link rel="wlwmanifest" type="application/wlwmanifest+xml" href="https://example.com/wp-includes/wlwmanifest.xml">
So the link[href*="wp-includes"]
selector will increasingly become unreliable for WordPress detection going forward. WordPress.com usually runs bleeding edge WordPress (pre-stable), which is perhaps why it is not showing up there now.
I suggest that the hasAPILinkElem
and hasWPIncludes
conditions be removed.
from library-detector-for-chrome.
It looks like originally when the test was introduced (2ab612a), it was checking for the meta[name="generator"]
tag or the page having a script
/link
that mentions wp-includes
. This was then changed in a8a6276 to make it a both/and condition. See #131 (review).
Pull request in question: #131
from library-detector-for-chrome.
Related Issues (20)
- New release?
- Extend to more than just JS libraries HOT 2
- Extension doen't work HOT 1
- Nuxt.js is not detected HOT 3
- Nuxt.js is still not detected in SSR mode HOT 3
- asset-manifest.json HOT 3
- Determine if numeric version field is OK
- Cannot log into Bitbucket HOT 4
- False detection of Ember on GMail and Google Docs HOT 1
- error in Workbox library block
- add lit-html library
- update README to reflect libraries
- update github.io for this project
- jQuery Version Detection Appears to Be Incorrect
- Is it possible to use this with html file? HOT 3
- libraries on FiveThirtyEight site?
- Publish usable module on npm
- Support for SvelteKit
- Support for Svelte
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from library-detector-for-chrome.