Possibly incorrect zfs/zpool parsing about zedenv

[zdykstra]

I'll update my installed copy of pyzfscmds and give it a try tonight. Thanks!

[johnramsden]

Hi there. Thanks for the feedback.

That is strange it's listing from the wrong pool.

Just to get a bit of information about what is happening during activation, can you activate void again with the --verbose flag. Don't forget to activate your regular boot environment after.

[zdykstra]

I recreated each step with --verbose. Below is the output, slightly sanitized due to znapzend backup information.

# ./zfs-bootenv/bin/zedenv create --verbose test-1
Creating Boot Environment:

Getting properties of boot/ROOT/test-1 for clones [{'snapshot': 'boot/ROOT/void@2018-05-30-22-065587', 'properties': ['mountpoint=/', 'org.znapzend:recursive=off', 'org.znapzend:dst_b_plan=1months=>1days,1years=>1weeks', 'org.znapzend:zend_delay=0', 'org.znapzend:post_znap_cmd=off', 'org.znapzend:tsformat=%Y-%m-%d-%H%M%S', 'org.znapzend:mbuffer_size=512M', 'org.znapzend:dst_a_plan=1months=>1days,1years=>1weeks', 'org.znapzend:dst_a=storage/backups/menegroth/boot/ROOT/void', 'org.znapzend:pre_znap_cmd=off', 'org.znapzend:enabled=on', 'org.znapzend:src_plan=1days=>1hours,1months=>1days', 'org.znapzend:dst_b=root@xxx:storage/backups/menegroth', 'org.znapzend:mbuffer=/usr/bin/mbuffer', 'canmount=off'], 'datasetchild': ''}]

-bash-4.4# ./zfs-bootenv/bin/zedenv activate --verbose test-1
Activating Boot Environment: test-1

Boot environment test-1 exists'

Mount dataset for customization

Mounted boot/ROOT/test-1 to /tmp/tmpyta6epge

Unmounted boot/ROOT/test-1 from /tmp/tmpyta6epge

Disabled automount for boot/ROOT/void

Promoted boot/ROOT/test-1.

# ./zfs-bootenv/bin/zedenv list --verbose
Listing Boot Environments:

Name    Active   Mountpoint   Creation              
void    N        /            Wed-May-9-19:54-2018  
test-1  R        -            Wed-May-30-22:02-2018 

The system was then rebooted into test-1.

# ./zfs-bootenv/bin/zedenv list --verbose
Listing Boot Environments:

Name    Active   Mountpoint                                 Creation              
void             /storage/backups/menegroth/boot/ROOT/void  Wed-May-9-19:54-2018  
test-1  NR       /                                          Wed-May-30-22:02-2018 

# ./zfs-bootenv/bin/zedenv activate void --verbose
Activating Boot Environment: void

Boot environment void exists'

Unmounting /storage/backups/menegroth/boot/ROOT/void.

Mount dataset for customization

Mounted boot/ROOT/void to /tmp/tmpct0scck0

Unmounted boot/ROOT/void from /tmp/tmpct0scck0

Disabled automount for boot/ROOT/test-1

Promoted boot/ROOT/void.

# df -h | grep void
#

Let me know if there's any additional information I can provide for you.

[johnramsden]

So I was able to reproduce it.

The problem occurs in pyzfscmds, I just pushed up a fix johnramsden/pyzfscmds@b20a964

In /proc/mounts it was finding:

storage/backups/menegroth/boot/ROOT/void /storage/backups/menegroth/boot/ROOT/void zfs rw,... 0 0

and thinking it found the dataset boot/ROOT/void. Now it will check for a match from the line start.

---

Can you make sure that fixes it for you, you'll need to update pyzfscmds.

[zdykstra]

Worked like a charm! I was able to activate a new environment, boot into it and then get the correct listing from zedenv list.

[johnramsden]

Awesome! Thanks for your help tracking down the bug.