Comments (3)
I totally agree with the first point.
For the second, I have mixed feelings. On a frontend, you want to keep going as far as possible. It is not reasonable to error out on a parsing error, and potentially prevent a user from completing a purchase. On the other hand you want to catch such errors as soon as possible — in dev, or in tests. However, from experience silent errors were a real hinderance when undefined randomly cropped into different layers.
from typedjson.
Personally, I am a fan of erroring early. Ignoring a problem in an early stage with the hope of things turning out okay almost always causes problems down the line. That being said, I believe we can keep the optimistic behavior available using the custom error handler. People that want the old behavior can use setGlobalConfig({errorHandler: console.error})
. I would recommend the default behavior to error, though, for the reasons mentioned point 2 and the silent errors being a hindrance as you said.
Regardless of whether we change the default behavior, both points are a breaking change and will require a new major version.
from typedjson.
WIP: master...MatthiasKunnen:error-handling
from typedjson.
Related Issues (20)
- [Discussion] `parse`, `toPlainJson`, `toPlainArray`, `toPlainMap`, `toPlainSet` should not return `undefined` HOT 1
- Using @json[Array,Set,Map]Member with a nullable type does not work
- Parsing array/set/map of primitive values HOT 2
- Array of Enum values HOT 4
- Unable to propagate current deserialization options in custom deserializer HOT 2
- Unable to parse complex nested type HOT 3
- URGENT ! TypeThunk broke everything for Angular Production Builds HOT 14
- Support for "pure object references"
- Indent with string | number | null
- Allow lazily define type in annotations / ES modules HOT 4
- Allow @jsonObject itself to specify custom serializer/deserializer functions.
- Lazy type definition syntax for `@jsonMemberArray`doesn't resolve for circular dependencies HOT 1
- Allow ignoring fields in a @jsonObject
- Polymorphic / generic types?
- Deserialize / convert missing / undefined / null fields?
- Not getting errors when field present in class is not present on JSON when parsing HOT 1
- I don't know how to use it in cocos creator 3.5+ HOT 5
- JS: [ERROR]: ReferenceError: Cannot access 'Pos' before initialization HOT 6
- Upgrade decorator syntax to Typescript 5.0 HOT 1
- Serializing odd-length ArrayBuffer fails
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typedjson.