Comments (3)
I agree this would be a useful feature to have.
However, I'm quite stripped for time right now (you can probably tell by the late reply π) so I will make absolutely no promises as to when I get to this.
Might be days or years, but if you're interested in seeing this soon I'm very happy to accept a PR!
from imagetools.
Really interested in this, though I wonder how it could work with multivariant queries. Should imagetools's default be to have image names mirror the queries (favicon_180w_180h.png)? Then if name=custom_name
is passed, apply it. I get hung up on how we could tackle multivariant queries for things such as w=1;2;3;4&quality=25;50;100
edit Jan. 8, 2023: I believe the name
param should be the base of the new url. If there are no multivariant queries apart from format, the name will be applied directly (e.g. favicon.svg?w=180&h=180&name=apple-touch-icon&png
-> apple-touch-icon.png
).
If there are multivariant queries, the differences should be applied as is done in the core imagetools tests (e.g. favicon.svg?w=180;192&h=180&name=apple-touch-icon&png
-> apple-touch-icon-w_180.png
)
from imagetools.
We should omit the hash when applying a name or provide an option to omit the hash altogether.
I'll leave you with a use-case example:
i.e. a file might end up named hero.a7929d7f.avif
, which might be used for OpenGraph/social media. Later, we regenerate the images, and the hash changes, but the post/thread/message is trying to look for hero.a7929d7f.avif
(even though it's now called hero.s12x43ac.avif
). I don't think LinkedIn, Slack, Facebook and likes are scraping for updated meta tags as much, or if at all?
βοΈ This happens on https://github.com/klyngeorg/website, which is re-building every day at noon. I'm not sure what to do with it yet, so this feature would be great :)
from imagetools.
Related Issues (20)
- Query strings don't work in dynamic imports with template literals containing variables HOT 8
- Upgrading to Vite 4.4.0 broke vite-imagetools HOT 5
- imagetools-core 4.0.4 `resolveConfigs` behavior change, `format` directive no longer working
- Build and build -w output differs HOT 6
- as=source and as=srcset both outputting srcset with all the same width params HOT 3
- manifest.json is generated incorrectly HOT 2
- Upgrading Vite-imagetools 5.0.8 throws an error from 4.x version HOT 2
- generateImageID causes tests to fail on CI HOT 3
- Vite example has a typo HOT 1
- Renaming picture fallback to img is not reflected in the document HOT 1
- Waste less effort transforming images
- Dependency on sharp not declared correctly for yarnβs PnP loader HOT 9
- Vite plugin crash HOT 2
- Loading attribute HOT 1
- v6 broken due to missing sharp 0.33 binariers HOT 3
- Some images get rotated for some reason HOT 14
- crop from / "gravity" HOT 1
- Error: Unable to parse color from string: ##ffaa22
- Pre-transform error: Failed to parse source for import analysis because the content contains invalid JS syntax
- How to receive access to original image in `extendOutputFormats` after v7.0.0? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from imagetools.