GithubHelp home page GithubHelp logo

Comments (4)

gw2princeps avatar gw2princeps commented on August 26, 2024

Hey,

we've kind of solved this issue (partly) as follows:

vite.config.js

const directives = {
  imagecardPreview: new URLSearchParams(
    'format=webp;jpg&width=438&height=250&position=entropy&quality=60&meta',
  ),
};

imagetools({
      include: '**/*.{heic,heif,avif,jpeg,jpg,png,tiff,webp,gif}*',
      defaultDirectives: (id) => {
        // scan images without search params. These kind of images might be
        // imported dynamically, where search params wont work.
        if (id.search === '') {
          if (id.pathname.includes('discretize-guides/guides/')) {
            return directives.imagecardPreview;
          }
        }
        return id.searchParams;
      },
})

You don't add any search params to the imported picture at all, but instead do "the work" in the defaultDirectives.

Maybe this piece of info could help you to create a solution for your problem?

from imagetools.

marcustyphoon avatar marcustyphoon commented on August 26, 2024

I believe this would potentially also be fixed by @rollup/plugin-dynamic-import-vars stripping query strings before it tries to use your template string as a glob to resolve all possible files you could be importing, then appending them again afterwards.

If this type of "query string in file import" path pattern is common, perhaps that would be a reasonable feature request for rollup/plugins?

from imagetools.

benmccann avatar benmccann commented on August 26, 2024

This is how Vite works and really isn't specific to imagetools at all. Vite can only handle static strings in imports and not dynamically constructed strings. Given that there isn't anything we can do about this in imagetools, I'm going to go ahead and close this

from imagetools.

benmccann avatar benmccann commented on August 26, 2024

Although I guess it's supposed to work in some cases: https://vitejs.dev/guide/assets.html#new-url-url-import-meta-url. However, that case would be covered by #327, so I'll leave this closed in favor of that issue.

from imagetools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.