Comments (6)
Yeah that makes sense why it was loading the last imported image.
And regarding your second issue with images not been generated in build mode, it seems like Vite is not picking up the import at all and that's why the images weren't included in the build. I don't know how or why it is different in build mode, but Vite-imagetools has nothing to do with that. It never gets told about any images in the first place.
I see, so I'm gonna create an issue over in the Vite repo. Thanks for debugging man!
from imagetools.
That's weird, I kinda expected this a bit to be honest since I changed the way images get generated in devmode completely (streaming the image to the browser instead of copying around a ton of files).
I didn't change the way images get generated in build mode at all so that's kinda weird.
I'll have a look a your repo and try to troubleshoot it!
Regarding examples,I think I'd be cool if you open up a PR for an example using solid when the time is right (i.e. the plugin actually works π
)
from imagetools.
I'll probably won't be able to get back to this before tomorrow or friday, I'm kinda busy right now, but don't worry we'll get that fixed ππ»
from imagetools.
That's weird, I kinda expected this a bit to be honest since I changed the way images get generated in devmode completely (streaming the image to the browser instead of copying around a ton of files).
I didn't change the way images get generated in build mode at all so that's kinda weird.
I'll have a look a your repo and try to troubleshoot it!
Regarding examples,I think I'd be cool if you open up a PR for an example using solid when the time is right (i.e. the plugin actually works π )
Yes I'll definitely create a PR once the lib works π
I'll probably won't be able to get back to this before tomorrow or friday, I'm kinda busy right now, but don't worry we'll get that fixed ππ»
No problem. I like your spirit!
from imagetools.
Alright, I've been experimenting a bit:
From what I can tell It doesn't seem like this is not a problem with imagetools directly but rather your specific setup since for me it worked perfectly.
To make sure though I changed how image IDs get generated. (It's not pushed yet I'll check out your repo first)
from imagetools.
I'm so stupid duh... You know what the issue was? π Images IDs were basically the url params hashed, since the same configuration always produces the same image, but it was only the url params and so the image path was not taken into account. How stupid...
Anyway, the fixed version should be available from npm soon!
Edit:
And regarding your second issue with images not been generated in build mode, it seems like Vite is not picking up the import at all and that's why the images weren't included in the build. I don't know how or why it is different in build mode, but Vite-imagetools has nothing to do with that. It never gets told about any images in the first place.
from imagetools.
Related Issues (20)
- as=source and as=srcset both outputting srcset with all the same width params HOT 3
- manifest.json is generated incorrectly HOT 2
- Upgrading Vite-imagetools 5.0.8 throws an error from 4.x version HOT 2
- generateImageID causes tests to fail on CI HOT 3
- Vite example has a typo HOT 1
- Renaming picture fallback to img is not reflected in the document HOT 1
- Waste less effort transforming images
- Dependency on sharp not declared correctly for yarnβs PnP loader HOT 7
- Vite plugin crash HOT 2
- Loading attribute HOT 1
- v6 broken due to missing sharp 0.33 binariers HOT 3
- Some images get rotated for some reason HOT 13
- crop from / "gravity" HOT 1
- Error: Unable to parse color from string: ##ffaa22
- Pre-transform error: Failed to parse source for import analysis because the content contains invalid JS syntax
- How to receive access to original image in `extendOutputFormats` after v7.0.0? HOT 2
- Resize image to fit in box
- Querying for GIF's metadata removes animation
- How to use with SSR
- Use the <Image> component HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from imagetools.