Extra icons are not shown in Repositories tool window about intellij-extra-icons-plugin

[Sheigutn]

Unfortunately I don't think this is possible considering the FileChooserDescriptor#getIcon in RepositoryBrowserPanel doesn't call the IconProvider, only FileType.getIcon() of the FileType it finds: https://github.com/JetBrains/intellij-community/blob/master/platform/vcs-impl/src/com/intellij/openapi/vcs/impl/RepositoryBrowser.kt#L80

A pull request to IntelliJ with this code replacing the method body would probably make it work (not totally sure though):

return IconUtil.getIcon(file, 0, project)

Edit: I just tested it by force returning this value while debugging the plugin and setting a breakpoint at that specific FileChooserDescriptor#getIcon, and it does indeed work:

So yeah, I think an issue on YouTrack and / or a pull request would be our only option :)

[jonathanlermitage]

Opened issue https://youtrack.jetbrains.com/issue/IDEA-239724

[jonathanlermitage]

@naftalmm @Sheigutn Good news! We should be able to customize icons by implementing FilePathIconProvider.
Unfortunately, this class has been introduced with IJ 2020.1, and I don't want to drop support for users who stick to IJ 2019. I think I will wait IJ 2020.2 release, then update minimal IJ version to 2020.1.

[jonathanlermitage]

Implemented in ide201 branch. It works well, icons are overridden in VCS views (local changes, log).

[naftalmm]

Awesome! Thank you!

[jonathanlermitage]

I will maintain and publish both master and ide201 branches, until IJ 2020.2 release.