GithubHelp home page GithubHelp logo

Comments (3)

ibrahimbutt avatar ibrahimbutt commented on August 19, 2024

@jonathontoon have you considered using TypeScript? It could help in making things more modular, as it allows for better OOP, if you choose to go the OOP route that is.

Besides that, have you considered testing? I would be happy to help in that regard, and thereon with refactoring.

from manifest.

jonathontoon avatar jonathontoon commented on August 19, 2024

@ibrahimbutt I think Typescript, while I personally like aspects of it would close off a lot of people with only fundamental Javascript knowledge who might have been able to contribute otherwise.

Testing should come a long at some point. As I'm mapping out what Manifest 2.0 might look like I think it should be considered at the start. I've personally only ever used basic snapshot testing for React components and Jest for Redux. Where might be a good place to start test-wise with vanilla Javascript?

from manifest.

ankitatechie avatar ankitatechie commented on August 19, 2024

@jonathontoon I think there is a great scope in CSS improvements as well. Right now selectors are tightly coupled to a specific HTML structure along with deep level nesting.

If you prefer, I can fix it up for you. Also, I can help you with making it more presentable with minimal code.

from manifest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.