Comments (3)
@jonathontoon have you considered using TypeScript? It could help in making things more modular, as it allows for better OOP, if you choose to go the OOP route that is.
Besides that, have you considered testing? I would be happy to help in that regard, and thereon with refactoring.
from manifest.
@ibrahimbutt I think Typescript, while I personally like aspects of it would close off a lot of people with only fundamental Javascript knowledge who might have been able to contribute otherwise.
Testing should come a long at some point. As I'm mapping out what Manifest 2.0 might look like I think it should be considered at the start. I've personally only ever used basic snapshot testing for React components and Jest for Redux. Where might be a good place to start test-wise with vanilla Javascript?
from manifest.
@jonathontoon I think there is a great scope in CSS improvements as well. Right now selectors are tightly coupled to a specific HTML structure along with deep level nesting.
If you prefer, I can fix it up for you. Also, I can help you with making it more presentable with minimal code.
from manifest.
Related Issues (20)
- Chrome New Tab Extension HOT 3
- Don't confirm memo deletion HOT 1
- Add dark mode shortcut tip to intial explainer memo
- Investigate performance on Safari HOT 3
- Disable rubberbanding scroll on iOS
- Convert URLs to links HOT 2
- Not able to toggle Dark Mode HOT 6
- PWA App Install Prompt
- Add notes with functionality HOT 1
- Support for Multiple Workspaces HOT 1
- Dark Mode does not persist in Safari HOT 2
- Enable Spellcheck to notes HOT 2
- Backup support HOT 1
- Some way to import/export all notes/positions etc HOT 2
- Codebase Style Questions. HOT 2
- Service worker offline cache not working HOT 1
- Make it scrollable so that more notes can be put there
- https://manifest.app/ is down ? HOT 1
- Feature Request: Note Taking Parameter in Web Manifest
- The heart icon is not visible on dark mode
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from manifest.