Comments (15)
Thanks, I'll take a look - I think it is because when the server error gets set there is no function to determine if it is valid once the field has been edited. I'll look at adding a property that determines if these errors should be cleared when the ng-model is updated. However, in the mean time you could call ngModelCtrl.removeExternalValidation.
https://github.com/jonsamwell/angular-auto-validate/blob/master/src/config/ngModelDecorator.js#L81
Thanks,
Jon
from angular-auto-validate.
Coluld You help me with removeExternalValidation, I've tried something like:
<input name="field" .... ng-change="myForm.field.removeExternalValidation('', true)" />
there is no key name, because it's a server custom message. Unfortunately it doesn't work...
Thanks,
Mateusz
from angular-auto-validate.
Have you tried just adding a key name when you invoke the setExternalValidatino('server-error',.....);
Then you could do the reverse here myForm.field.removeExternalValidation('server-error', true);
I'll do this enhancement soon as I think it is needed. I'll keep you posted. Let me know if this works as a temp workaround.
Thanks for using the module!
from angular-auto-validate.
The problem is that when I add 'server-error' then I would need to add a key to the lang, but messages from server are different. I'll wait then for the enhancement, I'm not in a hurry... :)
By the way I've translated the lang to Polish. I'll send it by email.
Thanks,
Mateusz
from angular-auto-validate.
Thanks for the translation! Right, I'll get on with the enhancement for you this week (just assume it is going to work for now).
from angular-auto-validate.
Any luck with this one?
Best regards,
Mateusz
from angular-auto-validate.
I'm going to tackle this tomorrow - sorry for the delay!
from angular-auto-validate.
Hi @emfor sorry for the delay. This issue should no be resolved in the latest release v1.18.4. The external validation errors are removed by default when the control or form is validated. To stop this behavior add the attribute to the parent form.
<form remove-external-validation-errors-on-submit="false" ng-submit="submit();">....</form>
Let me know how you get on.
Jon
from angular-auto-validate.
Hi @jonsamwell and @emfor
We recently upgraded our application to Angular 1.3.15 and this feature is giving me problems. Previously (Angular 1.2.18), I'd set server-side errors in the form form.setExternalValidation(message.field, null, message.message, true);
but now after editing the field, the external validation is gone but the default error message kicks in. By adding your new attribute, remove-external-validation-errors-on-submit="false"
I no longer get the default error message but some of my other validation no longer goes away, i.e. ng-minlength. The attribute name doesn't seem to make sense to fixing this initial issue and I now have your latest build and things are still not working right. I could use form.removeExternalValidation
, however, I don't have a good way to initiate that cleanly unless you all have some thoughts how to do that generically.
from angular-auto-validate.
I debugged a bit further - it appears that with the default settings (no remove-external-validation-errors-on-submit="false"), this gets called: removeAllExternalValidation
which indeed does remove the error but then in another event, the error gets populated with the default error message again because it can't find the key it was created by (in this case "null" or I've also tried ""). This appears to happen even if I set addToModelErrors
to false in setExternalValidation
....
from angular-auto-validate.
Also, it turns out that it wasn't angular version related, but I had pulled in an update version of angular-auto-validate back in March that looks like it broke this and didn't catch it until now. The newest version shows the same issue.
from angular-auto-validate.
I've continued debugging on this. It appears that modelCtrl.$invalid
stays true even though we've removed the external validation. This is causing the else condition on line 919 to be executed: validator.makeInvalid(el, errorMsg);
when in reality, it should never hit this block because it is actually valid. I'm looking for a solution.
from angular-auto-validate.
Sorry for the spam. I've figured out the issue. Here it is:
In removeAllExternalValidation
, the code incorrectly assumes we had previously set addToModelErrors
to true. So when looping over the ngModelCtrl.externalErrors and using those keys to then set the corresponding ngModelCtrl.$error key to true, we are in fact creating that key and setting it to true. Even though this is being set to true, ngModel is still considering this $invalid. Intead of this:
angular.forEach(ngModelCtrl.externalErrors, function (value, key) {
errorCollection[key] = true;
});
it looks like we should just delete the entry (if it exists) and it should cover both cases. Since this was an external error to begin with, when we are wiping them out, we don't care that the value exists on ngModelCtrl.$error and is true so we should just delete it. If addToModelErrors
was originally false, this delete still works (it just no-ops because the key never existed):
angular.forEach(ngModelCtrl.externalErrors, function (value, key) {
delete errorCollection[key];
});
If you think this change is reasonable, let me know. I can make a pull request or if you have time, you can make this small change.
from angular-auto-validate.
@jonsamwell Have you gotten a chance to see my comments above?
from angular-auto-validate.
@abobwhite Sorry for the late reply this should now be fixed in the latest release v1.18.8
from angular-auto-validate.
Related Issues (20)
- package.json has incorrect main attribute HOT 3
- angular-auto-validate with bower
- Is there any way to display more than one error message?
- Validation not working with material md-select
- After submit data remoove styling HOT 1
- Update npm registry HOT 3
- conflict with sb-admin admin template HOT 2
- Failed when using an angular expression in ng-pattern
- min and max error description wrong i18n es-co
- Prevent validating ng-hide elements
- Value {0} replace dont work when use myCustomErrorMessageResolver HOT 1
- Passing a parameter from a Custom Validator directive to errorMessages doesn't work unless you make errorMessages dash-case. HOT 1
- cannot validate ng-form or sections in a form
- Show server side errors using this package
- Validate when state redirection
- custom error message (help)
- auto validate for other plugins
- autovalidate intefering with ngRequired directive
- request/potential bug: allow validation when on $touched instead of on $dirty HOT 1
- Can we use this for Angular5 HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-auto-validate.