GithubHelp home page GithubHelp logo

Comments (9)

pjwalmsley avatar pjwalmsley commented on May 16, 2024

Have you added "register-custom-form-control" to your custom field? HTML elements are added to a HTML form controller, but custom elements are not. Angular auto validate uses the HTML form controller to decide what it should validate. Adding "register-custom-form-control" makes angular auto validate aware of your custom element.

Let me know if that works for you. :)

from angular-auto-validate.

mgsstms avatar mgsstms commented on May 16, 2024

Thank you, but it will not work for me ((
The module validates timepicker(shows errors or success), that's why no need to use the "register-custom-form-control".
In my case the problem is, that default bs3 element modifier adds "has-success has-feedback" style classes, which corrupts view (I still want to use default "has-success has-feedback" for other html elements like input, select etc). That's why I decided to create custom element modifier, where I removed only "has-success has-feedback" style classes in makeValid.

from angular-auto-validate.

pjwalmsley avatar pjwalmsley commented on May 16, 2024

Ok, so to clarify; The default element modifier corrupts the view. To get around that you have created a custom element modifier. You wish to apply this to only your timepicker with element-modifier, but that does not work (as in it does not register as the time modifier for that element)?

Personally never used it with a timepicker. I'll try to take a peek at it later tonight or tomorrow/tomorrow night.

from angular-auto-validate.

jonsamwell avatar jonsamwell commented on May 16, 2024

It must be something to do with the root element of the custom control @mgsstms could you do a reproducing plunker so I can debug it.

from angular-auto-validate.

mgsstms avatar mgsstms commented on May 16, 2024

I got the problem to reproduce this on plunker (shame on mr ((). I prepared the archive with 3 index files: https://www.dropbox.com/s/yvduzitcmem2mk5/_test.zip?dl=0

from angular-auto-validate.

jonsamwell avatar jonsamwell commented on May 16, 2024

Thanks for this!!! I'm on holiday until next Wednesday so I afraid I won't be able to look at it properly until then as I only have my tablet with me. Sorry for the inconvenience!

from angular-auto-validate.

mgsstms avatar mgsstms commented on May 16, 2024

Jon, thank you

from angular-auto-validate.

cmayankc avatar cmayankc commented on May 16, 2024

@mgsstms were you able to solve it?

from angular-auto-validate.

mgsstms avatar mgsstms commented on May 16, 2024

I updated template for timepicker template ('form-group' class has been removed for 'meridian' button)

from angular-auto-validate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.