GithubHelp home page GithubHelp logo

Comments (3)

joohoi avatar joohoi commented on September 25, 2024

Thanks for opening the issue. I believe most people are binding the acme-dns to a public interface. Possible access control is done on a separate layer (firewall, reverse proxy etc). This is also the reason the default value was changed, the service is designed to being accessed by multiple clients across the network, so binding to localhost as default didn't make much sense.

This is based on the expectations this project was originally built on, the decision is in no way final, and I'm up for discussion about the matter.

The README should definitely be synced with the actual config values in the end.

from acme-dns.

jvanasco avatar jvanasco commented on September 25, 2024

The README should definitely be synced with the actual config values in the end.

This was the main motivation for this ticket.

I believe most people are binding the acme-dns to a public interface. Possible access control is done on a separate layer (firewall, reverse proxy etc). This is also the reason the default value was changed, the service is designed to being accessed by multiple clients across the network, so binding to localhost as default didn't make much sense.

I agree that's the common usage, and expected the change was for that. What I failed to convey is that my concern is over the docs in strings and narratives that correspond to IP configuration. A lot of people who use this are unlikely to know the difference between localhost and the public address, and the risks/requirements involved with each. Example, for a long time Redis defaulted to 0.0.0.0 - which many people didn't expect - and glossed over that line... which lead to many servers hacked. I got burned by that when doing an update, and have been very sensitive to default listen configs ever since.

so it might make sense to use the default config as..

# listen ip. eg: 127.0.0.1 for localhost only; 0.0.0.0 for all/public address
ip = "0.0.0.0"

or even

# listen ip. eg: "127.0.0.1" for localhost only; "0.0.0.0" for all/public address
# most users will want to listen on the public address "0.0.0.0" so outside clients can access.
# if your only clients are on this machine or you have firewall rules, "127.0.0.1" may be preferred.
ip = ""

from acme-dns.

joohoi avatar joohoi commented on September 25, 2024

README.md is now pretty much up to sync with the config.cfg, the IP clarification is still pending.

from acme-dns.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.