GithubHelp home page GithubHelp logo

Comments (4)

mbabker avatar mbabker commented on August 19, 2024

CURLOPT_SSL_VERIFYPEER is disabled, which is insecure

I think that was me just being in a rush or tooling on my system being outdated, definitely no excuse for that other than bad developer.

SHA1 checksum is also insecure and should be replaced by somewhat stronger (current API does only provide MD5 and SHA1)

Our downloads platform is a modified version of Akeeba Release System which only supports those hashing methods. Pending acceptance of joomla/joomla-cms#17619 it'll need to be updated anyway to support the hash mechanisms used in that PR (sha256, sha384, and sha512). Once that's all in place then we can use stronger hashes for checksum.

I think a shell script is preferable over PHP

Agreed. But, I'm not as well versed with shell scripts as I am PHP so I went with what I knew (admittedly a lot of the shell scripting in place now is copy/paste from other resources with modifications for the workflow used here).

from docker-joomla.

mbabker avatar mbabker commented on August 19, 2024

The other point on a PHP script is I do more of the maintenance work on this repo from a MacBook and that causes some issues compared to other Linux platforms (I have to run the generate-stackbrew-library.sh file to generate the info to update the official images repo while tunneled into a Linux system because the readlink function throws errors on Mac).

from docker-joomla.

J0WI avatar J0WI commented on August 19, 2024

I removed CURLOPT_SSL_VERIFYPEER in #46

from docker-joomla.

J0WI avatar J0WI commented on August 19, 2024

PHP is replaced by shell in #63.

from docker-joomla.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.