Comments (6)
We actually have a longer line standard than others and I think 150 characters max is fine. Even at a 1280x1024 resolution, you can get 150 characters into the main display as long as your side panes in your IDE aren't set too wide.
from coding-standards.
I'm fine with 150 chars - IMHO horizontal scrolling is one thing we should avoid.
Imagine viewing those diffs here on GitHub with their fixed width.
Even looking at your screen shot I don't see an advantage..
Actually I would vote for 120 👅
from coding-standards.
But then, how do you avoid warnings in methods that have many params?
from coding-standards.
Wrap the method declaration to multiple lines or refactor the method declaration to accept an array with optional params. See https://github.com/joomla-framework/github-api/blob/master/src/Package/Issues.php#L198-L235 as an example.
from coding-standards.
I agree with @elkuku "horizontal scrolling is one thing we should avoid"
I would vote to leave at 150 or change to 120 to match the PHPCS default rule.
from coding-standards.
agreed 👍
Closing this issue.
from coding-standards.
Related Issues (20)
- [2.x] More Indention Issues With Closures HOT 2
- [4.0] Anonymous class support HOT 5
- [RFC] Multiline Signature Formatting HOT 4
- Analysis.md - 404 error on link from website HOT 2
- support for vscode HOT 8
- Indentation Confusion HOT 1
- Require visibility for class constants HOT 2
- Support new magic methods in PHP 7.4 HOT 3
- phpstorm 2019.2 doesn't follow settings HOT 2
- typos in README
- New Lines in XML-Files
- Indention checks fail with static Closure
- @since -> @SInCE HOT 1
- @headers link to invalid GitHub pages HOT 1
- Can we change standard from <br /> to <br> ? HOT 4
- Documentation - How should database table and column names be written HOT 3
- [PHP8] Document named arguments BC policy HOT 1
- Links in joomla site not working HOT 1
- problem in alternative syntax (controller statements)
- PSR12 mention in README.md
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coding-standards.