Comments (4)
What do you think about an option to allow you to pass back the host that is making the request in the Access-Control-Allow-Origin
header -- in other words, instead of *
it just looks at who's calling and returns that host name -- this would allow authenticated requests to come from anywhere.
from serverless-cors-plugin.
Thank again for reporting! You are getting this error in the browser console, right?
I suspect you have set the withCredentials
option to true
in whatever JS library that is performing the XHR request? If yes, did you mean to make authorized requests?
If you really want to make authorized requests:
- The
Access-Control-Allow-Credentials
header has to be set totrue
. However, the plugin does not support this header at this time. I'll probably release support for this today or tomorrow. - You have to set a specific host in the
Access-Control-Allow-Origin
header. CORS doen not allow a wildcard (*) origin for authorized requests.
from serverless-cors-plugin.
That was it, thank you!
Also thank you for this plugin its a huge time saver.
I am using https://github.com/Netflix/falcor-http-datasource to make requests and it has some odd defaults.
from serverless-cors-plugin.
@chadkouse Thanks for reaching out! That is indeed something I've been thinking about and it definitely could be an interesting addition for authorized requests! I'll create an issue for this.
from serverless-cors-plugin.
Related Issues (20)
- sls dash deploy --all fails due to missing sPath HOT 3
- Path/Query parameters not added to Options methods causing invalid API template export HOT 5
- OPTIONS mock type HOT 3
- v2.1 exported CORS correctly, v3.1 no longer works HOT 2
- Pass caller identity from API GW to execute lambda HOT 4
- Custom Header support HOT 6
- PUT requests fail HOT 1
- Make plugin compatible with Serverless v0.5 HOT 8
- Enable CORS for all endpoints HOT 5
- Deploy OPTIONS without `-a` HOT 13
- Problem deploying OPTIONS endpoints HOT 7
- OPTIONS error when using custom authorizerFunction HOT 1
- using allowCredentials with s3.amazonaws.com HOT 2
- Still need to use the "Enable CORS" feature on AWS Console to get CORS to work HOT 6
- Preflight CORS with Lambda Proxy Integration HOT 1
- Serverless 1.7 compatibility HOT 3
- Preflight endpoints not deployed by default HOT 3
- Internal Server Error on OPTIONS endpoint HOT 1
- lodash dependency causing _.pluck error in _createPreflightEndpoints HOT 2
- sls templates break the plugin HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from serverless-cors-plugin.