GithubHelp home page GithubHelp logo

Comments (4)

adamgilmour avatar adamgilmour commented on May 19, 2024 1

Also having issues with this. I need to modify the input styling (field.css). But because it's a global component that's imported into other components (addressForm.js etc) the components that depend on it also need copying across to the "child" theme or import paths altered in some of the components to point to the "parent" theme, so it severs the chain.

With this in mind you're probably best just copying copying all the components across before you start a theme or just working on veniaUi directly in the first place... or am I completely missing something obvs? ¯_(ツ)_/¯

I wish Magento would bring out some best bloody practises using their PWA setup. Always such limited documentation from those guys!!!

from fallback-studio.

Jordaneisenburger avatar Jordaneisenburger commented on May 19, 2024

Kinda short on time at the moment but you can take a look at https://github.com/Jordaneisenburger/fallback-studio/blob/master/src/example-company/example-shop/componentOverrideMapping.js

from fallback-studio.

adamgilmour avatar adamgilmour commented on May 19, 2024

@Jordaneisenburger Sorry, I'm a bit confused.. please can you explain what the componentOverrideMapping.js does or how to utilise it when you have time?

If I need to make a change to a global component such as field.js, I need to copy it over to the theme. There are a few other components that import the component:
image
Do I need to copy these over to the theme so their import paths point to the correct field.js component?

from fallback-studio.

Jordaneisenburger avatar Jordaneisenburger commented on May 19, 2024

It basically replaces the left string with right string whenever it's used. So if you wanna overwrite field.js you can replace it with your own in componentOverrideMapping.js

from fallback-studio.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.