GithubHelp home page GithubHelp logo

Comments (34)

dabeeeenster avatar dabeeeenster commented on June 18, 2024

Think this is due to 0.6 - http://install.meteor.com/ no longer has reference to VERSION anywhere which I think the buildpack expects?

from heroku-buildpack-meteor.

dimfisch avatar dimfisch commented on June 18, 2024

Any idea how to solve this?

from heroku-buildpack-meteor.

dabeeeenster avatar dabeeeenster commented on June 18, 2024

Not really - you could try hard coding the URL of the 0.6 meteor install package - the URL is https://d3fm2vapipm3k9.cloudfront.net/bootstrap/0.6.0/meteor-bootstrap-Linux_i686.tar.gz


Ben Rometsch (http://flavors.me/dabeeeenster) - Director
Solid State Group (http://www.solidstategroup.com/)
Tel: +44 (0)20 7613 7223

On Friday, 5 April 2013 at 17:38, dimfisch wrote:

Any idea how to solve this?


Reply to this email directly or view it on GitHub (#13 (comment)).

from heroku-buildpack-meteor.

jordansissel avatar jordansissel commented on June 18, 2024

Looks like the meteor folks completely rewrote their install script, so the 'compile' script for the buildpack will need to be fixed to compensate.

from heroku-buildpack-meteor.

dimfisch avatar dimfisch commented on June 18, 2024

Thanks, Jordan. Any idea how soon this can be done? Any help needed? (not that I think I can help much, but still, I'd be willing to give it a shot :)

from heroku-buildpack-meteor.

jordansissel avatar jordansissel commented on June 18, 2024

No ETA for me, probably would be easy for someone to patch though.

from heroku-buildpack-meteor.

dimfisch avatar dimfisch commented on June 18, 2024

Any chance you could spend a few minutes with me on Skype to give me a sense of what needs to be done and how?

from heroku-buildpack-meteor.

madsmao avatar madsmao commented on June 18, 2024

I have been looking at this. I tried hardcoding the version number into compile and that got me past the initial error. However, I then got this sucker:

Unpacking meteor
Building meteor bundle
/tmp/buildpack_2wunkdrmnx0zj/bin/compile: 41: meteor: not found
tar: /app/tmp/repo.git/.cache/bundle.tar.gz: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now
tar: Child returned status 2
tar: Exiting with failure status due to previous errors

As far as I can see it might be related to the path, but I really am guessing here. I'll do some more hacking in the morning.

from heroku-buildpack-meteor.

madsmao avatar madsmao commented on June 18, 2024

On a side note: it really would make sense to detect the appropriate version of meteor for a given project, instead of just assuming that you want the latest version.

from heroku-buildpack-meteor.

dimfisch avatar dimfisch commented on June 18, 2024

Totally agree. I'm developing on Windows, so still on 0.5.9

from heroku-buildpack-meteor.

jordansissel avatar jordansissel commented on June 18, 2024

Indeed; open to support for that. Probably worth looking into how the ruby buildpack does it (which I believe has version selections)

from heroku-buildpack-meteor.

dabeeeenster avatar dabeeeenster commented on June 18, 2024

@madsmao given that the meteor project itself is now doing this it would seem like the right way to go. There's also a hard dependency on that install.meteor.com script which is a shame as it could break this project in the future...

from heroku-buildpack-meteor.

madsmao avatar madsmao commented on June 18, 2024

I am still working on fixing this issue. I appreciate any support on this issue, as I am a total noob when it comes to buildpacks (the debugging workflow has it's quirks).

I am currently at a point where I feel the need to pretty much start from scratch and embrace the new features introduced in Meteor 0.6.0 for version control etc.

@dabeeeenster you are right that the hard dependency on install.meteor.com is not cool. I pretty much see two ways to avoid this:

  1. Embrace the install script and use it as a part of the build pack
  2. Check out the source from Github and do a full build

The first approach will probably make the build script run faster, whereas the second approach might cause less issues down the road if the Meteor team decides to make changes to install.meteor.com. I'll go with the first option for now (if I can get it working) because I believe it is the fastest path to a working buildpack.

from heroku-buildpack-meteor.

madsmao avatar madsmao commented on June 18, 2024

I now have a working buildpack that supports 0.6.0. Feel free to take it for a spin!

This app is running on the new buildpack: http://v8s-bp.herokuapp.com/
The buildpack is here: https://github.com/v8squirrel/heroku-buildpack-meteor

CAUTION: This is very much a work in progress. I have yet to test that stuff like database access actually works, but I thought I would let you guys know. It's also worth mentioning that my changes will probably make the buildpack incompatible with earlier releases of Meteor.

I'll continue my work on this and keep you guys posted.

from heroku-buildpack-meteor.

madsmao avatar madsmao commented on June 18, 2024

I have made a bit of a mess of my commit history (tried to clean all my 'Random commit' messages out of the log). Hope things will still work for everyone.

from heroku-buildpack-meteor.

adnissen avatar adnissen commented on June 18, 2024

Have you tested it with the database stuff? I'd like to use this, but I'm slightly worried that it'll just break everything in my db since you mentioned it.

from heroku-buildpack-meteor.

madsmao avatar madsmao commented on June 18, 2024

I tested it with a database and everything works as expected. Can't hurt to do a quick backup first though.

from heroku-buildpack-meteor.

dimfisch avatar dimfisch commented on June 18, 2024

Just to be clear, this is just for 0.6.0, any other version won't work, right?

from heroku-buildpack-meteor.

madsmao avatar madsmao commented on June 18, 2024

Correct. Older versions won't work. Future versions should though.

from heroku-buildpack-meteor.

dimfisch avatar dimfisch commented on June 18, 2024

Would it be complicated to add support for 0.5.9?
Basically have the buildpack work just like it did 5 days ago...?

from heroku-buildpack-meteor.

madsmao avatar madsmao commented on June 18, 2024

Making the buildpack work like it did 5 days ago (just for 0.5.9) should be possible by creating a fork of @jordansissel's code and simply hardcoding the version number into bin/compile. That should do the trick.

from heroku-buildpack-meteor.

dimfisch avatar dimfisch commented on June 18, 2024

Wow! As simple as that, huh?!
So that means replacing

PACKAGE=meteor_${VERSION}-1_amd64.deb

with

PACKAGE=meteor_0.5.9-1_amd64.deb

?

from heroku-buildpack-meteor.

madsmao avatar madsmao commented on June 18, 2024

Yeah, that should do it. Give it a try :-)

from heroku-buildpack-meteor.

madsmao avatar madsmao commented on June 18, 2024

Also, you can comment out the line(s) that fetch information about the version number from install.meteor.com.

from heroku-buildpack-meteor.

dimfisch avatar dimfisch commented on June 18, 2024

Didn't work, I got the following error:
Unpacking meteor ar: /app/tmp/repo.git/.cache/meteor_-1_amd64.deb: File format not recognized

I don't think it likes the dots in that file name.

On your second reply, which lines are you referring to?

from heroku-buildpack-meteor.

jordansissel avatar jordansissel commented on June 18, 2024

you can make it tunable using an environment variable to set the version instead of querying it from meteor.com; this would let you use heroku config to set the version of meteor.

from heroku-buildpack-meteor.

jordansissel avatar jordansissel commented on June 18, 2024

I can probably cobble together a hack that supports you setting METEOR_VERSION

from heroku-buildpack-meteor.

jordansissel avatar jordansissel commented on June 18, 2024

Looks like heroku buildpacks have changed behavior?

tar: /app/tmp/repo.git/.cache/bundle.tar.gz: Cannot open: No such file or directory

Looks like CACHE_DIR isn't valid anymore? Wonderful times...

from heroku-buildpack-meteor.

jordansissel avatar jordansissel commented on June 18, 2024

I've confirmed master of this buildpack repo now works for meteor apps.

from heroku-buildpack-meteor.

jordansissel avatar jordansissel commented on June 18, 2024

I'll have a go adding 0.6.x support too

from heroku-buildpack-meteor.

jordansissel avatar jordansissel commented on June 18, 2024

Best I can tell, 'heroku config' environment variables are not exposed to the 'compile' step

% git push heroku 
...

GIT_DIR=.
HOME=/app/
LOGNAME=u26769
LOG_TOKEN=t.9e79a5be-dfa2-446e-9f83-f6b4ebbc4eb7
MAIL=/var/mail/u26769
PATH=/tmp/build_1iup2aqv2o9qp/.meteor/local/usr/bin:/tmp/build_1iup2aqv2o9qp/.meteor/local/usr/lib/meteor/bin::/usr/local/bin:/usr/local/sbin:/usr/bin:/bin:/usr/sbin:/sbin
PWD=/app/tmp/repo.git
SHELL=/bin/bash
SHLVL=1
SSH_CLIENT=10.4.18.11 40679 49712
SSH_CONNECTION=10.4.18.11 40679 10.227.3.45 49712
USER=u26769
_=/usr/bin/git-receive-pack
Fetching meteor deb package

from heroku-buildpack-meteor.

jordansissel avatar jordansissel commented on June 18, 2024

Based on the above, I do not know if it is possible to make the version of meteor configurable.

I expected the 'ruby' buildpack to show signs of version choosing, but it does not. Even the Ruby buildpack, which is probably 'state of the art' in terms of buildpack practices, says that if you want to change the version of something to fork the buildpack and edit the hard-coded versions in the config.

from heroku-buildpack-meteor.

jordansissel avatar jordansissel commented on June 18, 2024
  • the buildpack is now pinned at version 0.5.9 until someone provides patches to make 0.6.0 work
  • based on research, I believe heroku buildpacks are not featured enough to permit passing parameters to a buildpack.

Marking closed.

from heroku-buildpack-meteor.

metadaddy avatar metadaddy commented on June 18, 2024

If it's useful, there's a Heroku Labs feature that lets you set env vars during slug compilation: https://devcenter.heroku.com/articles/labs-user-env-compile

from heroku-buildpack-meteor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.