GithubHelp home page GithubHelp logo

Comments (14)

joshbuchea avatar joshbuchea commented on June 1, 2024 3

Hey gentlemen, I'm not sure that viewport-fit=cover is a good default or that removing shrink-to-fit=no is necessary. Do either of you have any references to support these changes being better defaults? I'm going to go ahead and revert for now. In the future I would prefer to discuss changes to the recommended defaults. Thanks!

from head.

scottaohara avatar scottaohara commented on June 1, 2024 2

Report: https://www.scottohara.me/blog/2018/12/11/shrink-to-fit.html which contains more testing of earlier iOS versions.

tldr; shrink-to-fit=no became irrelevant during the iOS 9.3 lifecyle and beyond.

from head.

scottaohara avatar scottaohara commented on June 1, 2024 2

FWIW: pull request to remove shrink-to-fit from HTML5 boiler plate

from head.

scottaohara avatar scottaohara commented on June 1, 2024

thanks!

from head.

e110c0 avatar e110c0 commented on June 1, 2024

I did not expect that change to just be merged TBH. I'd rather start a discussion and find out what a good default is.

Adding it to the documentation of what can be done and what it is for might be the better solution.

from head.

scottaohara avatar scottaohara commented on June 1, 2024

yup. i jumped the gun here by not providing reasoning why i merged the change.

Upon review / testing on iOS devices running v10.3, v11.x and 12.1 shrink-to-fit is no longer recognized or needed.

I'll be posting a write up about this soon.

from head.

joshbuchea avatar joshbuchea commented on June 1, 2024

Apologies for the late response, open source has been low on my list of priorities lately. Excellent writeup @scottaohara 👌 I'm on-board, let's remove shink-to-fit=no.

from head.

joshbuchea avatar joshbuchea commented on June 1, 2024

Also — FWIW @e110c0 I think we definitely should include viewport-fit=cover somewhere, just not sure if it belongs in the recommended minimum as it seems there are reports of it breaking websites by covering navigation and other controls in some cases.

from head.

scottaohara avatar scottaohara commented on June 1, 2024

no worries @joshbuchea :)

from head.

joshbuchea avatar joshbuchea commented on June 1, 2024

@scottaohara I'm not sure how large this dataset is but, iOS 9.0-9.2.x usage is currently only @ 0.17% https://data.apteligent.com/ios/

from head.

scottaohara avatar scottaohara commented on June 1, 2024

oh that's interesting. thank you @joshbuchea. going to update my article with that link. Coupled with the one I already had in the article, more data points the better. :)

from head.

joshbuchea avatar joshbuchea commented on June 1, 2024

Oh yeah and almost forgot — @scottaohara thank you for doing that research and for publishing your findings 💯

from head.

scottaohara avatar scottaohara commented on June 1, 2024

i like to share :)

from head.

e110c0 avatar e110c0 commented on June 1, 2024

@scottaohara totally agree it's not a recommended minimum.

Having all possible options in the documentation would be nice. I still haven't figured out all pitfalls of it, so not comfortable with creating a PR at the moment

from head.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.