GithubHelp home page GithubHelp logo

Comments (3)

wbobeirne avatar wbobeirne commented on June 12, 2024 1

Can you share the code for your link? Joule tries to intercept clicks on links that start with lightning:, you can read the code here: https://github.com/joule-labs/joule-extension/blob/develop/src/content_script/index.ts#L48-L67

Unfortunately this is really finnicky; browsers don't let you intercept link open intents so certain ways of opening links don't work (e.g. window.location.href = 'lightning:... or window.replace('lightning:...')) so this only works on clicking <a> tag links.

from joule-extension.

wbobeirne avatar wbobeirne commented on June 12, 2024 1

The issue was that my link started with ln...

Ah yeah every link needs to start with [protocol]:[value] regardless of what it's linking to. For instance mailto:[email protected] or bitcoin:bitcoin:175tWpb8K1S7NmH4Zx6rewF9WQrcZv245W. It's not a valid URI if it doesn't include the protocol and a colon first, in this case lightning:ln....

from joule-extension.

spirobel avatar spirobel commented on June 12, 2024

wow thanks a lot! that is really straight forward. Yesterday I looked up how browser plugins can handle custom protocols so I immediately understood the code. The issue was that my link started with ln... I just copy and pasted it from joule. I didnt know that I would have to add lightning in front, but in hindsight it makes a lot of sense.
I will retry and check if it works with the protocol: in front.

Thanks a lot! Joule is really cool!

from joule-extension.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.