Champions: Return to Arms memcard hang about play-

[bigianb]

The hang was because the param was not being filled in when the file does not have a valid handle.

The code below solves that ... but it still has problems - I think because the params are not right. Needs more investigation.

void CMcServ::Read(uint32* args, uint32 argsSize, uint32* ret, uint32 retSize, uint8* ram)
{
	FILECMD* cmd = reinterpret_cast<FILECMD*>(args);

	CLog::GetInstance().Print(LOG_NAME, "Read(handle = %i, size = 0x%08X, bufferAddress = 0x%08X, paramAddress = 0x%08X);\r\n",
	                          cmd->handle, cmd->size, cmd->bufferAddress, cmd->paramAddress);

    if(cmd->paramAddress != 0)
    {
        //This param buffer is used in the callback after calling this method... No clue what it's for
        reinterpret_cast<uint32*>(&ram[cmd->paramAddress])[0] = 0;
        reinterpret_cast<uint32*>(&ram[cmd->paramAddress])[1] = 0;
    }
    
    assert(cmd->bufferAddress != 0);
    void* dst = &ram[cmd->bufferAddress];
    
	auto file = GetFileFromHandle(cmd->handle);
	if(file == nullptr)
	{
		ret[0] = -4;
        } 
        else if(file->IsEOF())
	{
		ret[0] = 0;
	}
	else
	{
		ret[0] = static_cast<uint32>(file->Read(dst, cmd->size));

		//Sync pointer for games that write after read without seeking or flushing
		file->Seek(file->Tell(), Framework::STREAM_SEEK_SET);
	}
}