Is there OAuth 2 support? about hubspot3

[jpetrucciani]

This should now be on pip as version 3.2.2!

I'll go ahead and close this issue, but feel free to open it back up if you have any more issues!

[Nusnus]

Hey @jpetrucciani , your latest commit fixes the bug!
I can finally do contacts.ContactsClient(access_token=hubspotSession['accessToken'], refresh_token=hubspotSession['refreshToken'], debug=True) and it works as I expect including building the headers as defined in their official docs (checking with debug=True) and basically everything works exactly as if I used the API key method!

Well done mate!

[jpetrucciani]

You should be able to use an access_token and a refresh_token instead of an api_key when initializing any of the clients!

hubspot3/hubspot3/base.py

Lines 36 to 45 in ff5e4b9

	def __init__(
	self,
	api_key=None,
	timeout=10,
	mixins=None,
	access_token=None,
	refresh_token=None,
	client_id=None,
	**extra_options
	):

Example:

# instead of:
deals_client = DealsClient(api_key=API_KEY)

# you can do:
deals_client = DealsClient(access_token=ACCESS_TOKEN, refresh_token=REFRESH_TOKEN)

You should be able to do this with any of the current clients!

[Nusnus]

It doesn't work unfortunately.
It sets the access token in the URL itself instead of in the header so it doesn't work (should have Authorization: Bearer {token} header).

Also, I see the utils.refresh_access_token() uses an outdated endpoint.
See here: https://developers.hubspot.com/docs/methods/oauth2/refresh-access-token

I actually need to use the OAuth authentication method and I really like to use the library so I won't have to manually implement all of the clients you've already implemented.

Would it be possible to release a quick fix for this please?

Thanks!

[jpetrucciani]

Hmm, sorry about that! I haven't had to use the OAuth methods yet so that functionality hasn't been touched in a while.

I've pushed some small fixes for that that should work (12937eb), however, I don't currently have access to an OAuth setup to test it out. I've basically just changed it to the newer refresh endpoint, and added that Authorization header instead of appending the access_token to the params.

If you could pull that commit down locally to test and let me know if that works the way you are expecting, I can push that to pip!

[Nusnus]

Sure man! Be glad to help - win-win situation here ;)

Seems there's a bug in the commit - will comment there with the technical part.
Once fixed just LMK and I'll pull the commit and test again.

[jpetrucciani]

Awesome! I'll get this fix deployed to pip soon