Comments (5)
If we are able to define guidelines and goals on this topic I could help :)
Letting the choice to the user regarding the outputs / input could be interesting. But I am afraid that it would be complicated to handle if users have to deal with an optional boolean flag each time they call a client.
Maybe prettify_output
(and input
?) could be given once for all at the instantiation of the clients?
Regarding the outputs, I am currently dealing with those inconstancies in my code by checking the presence of the properties
key in the data returned by the library. Not ideal but it simple and it works well.
from hubspot3.
Yeah at the moment there isn't a ton of consistency across all of the clients and their methods. I'd love to standardize this a bit more across the board, but also potentially add prettifying as an optional functionality (similar to what was done here recently).
It would be cool to add functionality to be able to use the prettified representations in inputs as well!
from hubspot3.
Oh yeah that's a good point! It'd probably be best as a Client level flag, potentially with the ability to override on a per-call basis (as to avoid having two instances of a client, one pretty, one not). It could then also inherit from a top level client and propagate to all of the different clients as properties of the Hubspot3
client.
Language to consider:
pretty_output
andpretty_input
prettify_output
andprettify_input
(may sound a bit weird for input)minimal_output
andminimal_input
simple_output
andsimple_input
- something else?
Then if we can decide on wording for that, we can slowly start converting all calls to use this new functionality. I'll have a look through to see what is most common so we can understand what the default may need to be, and then perhaps put together a todo list for which clients need to be changed
from hubspot3.
Sound good to me!
from hubspot3.
Sorry I've been a bit stalled on this - I haven't forgotten! Things have been a bit crazy at work recently.
I should be able to get around to this sometime next week!
from hubspot3.
Related Issues (20)
- Async implementation is in the roadmap? HOT 1
- Updating a Hubspot Company is not doing anything
- Get data from HubspotConflict
- Review API and use version 3 instead of 1?
- Unable to pass params to contacts.get_all() HOT 1
- Help needed - Is there any way to load all the events using Web Analytics API
- Error on calling client.usage_limits
- Feature request: support for /email/public/v1/events endpoint
- ACCESS TOKEN example HOT 1
- Disabling auto-retry spams out warnings HOT 2
- Emit metrics about API calls
- Proposal to improve support for oauth2 authentication with multiple clients HOT 1
- Use Requests HOT 1
- Trouble using the command line "AttributeError: 'int' object has no attribute 'value'" HOT 16
- Not found response on create or update pipeline HOT 2
- Question: Transactional Email API HOT 1
- Result window too large when querying recently modified companies HOT 3
- Engagement API, function get_associated contains two print statements HOT 2
- No verbose output to log in case of retries
- get_all() fails HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hubspot3.