GithubHelp home page GithubHelp logo

Comments (4)

jquense avatar jquense commented on July 19, 2024

Hey there thanks for the report.

I am pretty sure your right, and this a classic "timeout fires after the thing has been removed" bug. I should have been paying more attention to :P. I'll add a check and you should be good to go.

To your side note, a quick glance and test on the docs site indicates that duration is being passed down just fine. Unfortunately a duration of zero doesn't actually solve the issue b/c while its not animating over time the animation callback is still getting called async: setTimeout(cb, 0) so it can still suffer this bug.

from react-widgets.

vladimir-rovensky avatar vladimir-rovensky commented on July 19, 2024

Hey there

We're definitely on the right track here, but there's still an error, even if I apply your fix locally. This time it happens in _handleDoneLeaving (again in ReplaceTransitionGroup), which tries to setState after the component has unmounted. Could we add one more check in _handleDoneLeaving?

Many thanks for your work on this project BTW, I appreciate the effort you're putting into this.

from react-widgets.

jquense avatar jquense commented on July 19, 2024

Glad you are enjoying the library, I've added an additional check, let me know if that finally solves it?

from react-widgets.

vladimir-rovensky avatar vladimir-rovensky commented on July 19, 2024

Works nicely now, thanks again!

from react-widgets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.