More Accesibility issues about react-widgets

[jquense]

Hey there,

thanks for this. I will look into it! Some of these are definately false positives...the ones complaining about "associated text" can be fixed by providing a name= prop.

Thanks again, i will do more research and se if I can clean these up :)

[ferrannp]

Hey, thank you for so fast response. I tried a name as a prop, now I have an input like this:

Now looks like:
<input class="rw-input" type="text" data-reactid=".0.3.3.0.1.1.0.$=13:0.0.1.0.1.0.0.2.1.2.0" aria-readonly="false" aria-disabled="true" value="" role="combobox" name="someName" placeholder="Start Date" aria-haspopup="true" aria-owns="myID_cal myID_time_listbox" aria-busy="false" aria-expanded="false" disabled="true">

But I am still getting same violations (this one is the first one).

[jquense]

Maybe i just don't understand what the error is then. as far as I can tell according the spec a name is an associated text...It might mean you also need a label associated with it

[ferrannp]

I think it talks about labels:

Each FORM control must have associated labels that are not of type "hidden". INPUT controls of type "submit", "reset", and "button" require text to be set in the "value" attribute. INPUT controls of type "image" require text to be set in the "alt" attribute. All other FORM controls are associated with text via the LABEL element. A LABEL is attached to a specific form control through the use of the "for" attribute. The value of the "for" attribute must be the same as the value of the "id" attribute of the form control. The aria-labelledby property can also be used to associate label for form controls.

[jquense]

Yeah ok, So the correct thing to do would be to pass the id attribute down to the widget input so you could actually create a label for it, since I can't change that without breaking existing code, I think the next best thing is to make sure the labelled-by attribute gets passed to the input. look for that in the next release hopefully.