GithubHelp home page GithubHelp logo

Comments (5)

dmethvin avatar dmethvin commented on May 22, 2024

You can't use onbeforeunload because one of the things that handler might do is ask "There are server requests in progress. Do you want to stop those, exit, and lose your work?" If the user were to cancel the damage would still be done.

I agree the dependency here is unfortunate and undesired.

from jquery.

gibson042 avatar gibson042 commented on May 22, 2024

We could guard the whole block on jQuery.fn.on, though, basically restricting the fix to more complete builds.

from jquery.

markelog avatar markelog commented on May 22, 2024

We're not doing anything special for unload event in effects module and that hack is relative for oldIE only, plus we already have guard through checking for presence of ActiveXObject object (although this code path will be executed in newer version of IE).

So why we can't use attachEvent method directly?

from jquery.

dmethvin avatar dmethvin commented on May 22, 2024

@gibson042 Guarding the block works, and justifies not having it listed as a dependency I suppose.

@markelog I had remembered, falsely it seems, that unload didn't work with attachEvent. So perhaps we can just check for attachEvent as our feature detect and attach it that way? This problem is supposed to be fixed in IE11 where attachEvent isn't present.

from jquery.

markelog avatar markelog commented on May 22, 2024

So perhaps we can just check for attachEvent as our feature detect and attach it that way?

I think so, yes. I can provide patch today.

from jquery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.