GithubHelp home page GithubHelp logo

Comments (5)

jramseye avatar jramseye commented on July 20, 2024

Hi! I think I've fixed 1 (just save by IMAGEID:IMAGEID), but I don't really understand 2.
My thoughts:
We only need to save by ID when the image is a : image. Otherwise, we can just save by name:tag. Of the none:none images, each one will have a different image ID. I don't think there is ever a case where two none:none images have the same image ID? If there isn't, then we can just save the none:none images by image ID, and the rest as name:tag, and be fine. (I think?)

from docker-migrate.

jramseye avatar jramseye commented on July 20, 2024

Pushed a fix to 1

from docker-migrate.

jramseye avatar jramseye commented on July 20, 2024

Any thoughts on 2?

from docker-migrate.

luwensu avatar luwensu commented on July 20, 2024

Sorry for the late reply, i thought the scenario too complex(I wanted to cover all supported filesystem ,and after read the docker code, i found it's not related this script......)
I tried it before, lgtm :)

from docker-migrate.

jramseye avatar jramseye commented on July 20, 2024

No worries! Sounds good. Thanks! :)

from docker-migrate.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.