Comments (5)
@jrendel Thank you for the update. I did test with the following Cartfile
:
github "jrendel/SwiftKeychainWrapper"
And run carthage update
in the same project folder. After a couple seconds, the SwiftKeychainWrapper.framework built under ./Carthage/Build/iOS/
.
Everything works fine apart from the warnings:
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:129:16: warning: immutable value 'retrievedString' was never used; consider replacing with '_' or removing it
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:192:13: warning: variable 'testInt' was never mutated; consider changing to 'let' constant
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:193:13: warning: variable 'myTestObject' was never mutated; consider changing to 'let' constant
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:208:16: warning: immutable value 'retrievedObject' was never used; consider replacing with '_' or removing it
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:248:16: warning: immutable value 'retrievedData' was never used; consider replacing with '_' or removing it
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:129:16: warning: immutable value 'retrievedString' was never used; consider replacing with '_' or removing it
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:192:13: warning: variable 'testInt' was never mutated; consider changing to 'let' constant
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:193:13: warning: variable 'myTestObject' was never mutated; consider changing to 'let' constant
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:208:16: warning: immutable value 'retrievedObject' was never used; consider replacing with '_' or removing it
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:248:16: warning: immutable value 'retrievedData' was never used; consider replacing with '_' or removing it
I guess you should upgrade to Xcode 7.1 and Swift 2.1.
In addition, a simple instruction in README talking about how to build this lib with Carthage would be nice. Take an example:
https://github.com/alamofire/alamofire
from swiftkeychainwrapper.
Any indications when this warnings might be fixed?
from swiftkeychainwrapper.
Not on the roadmap yet?
from swiftkeychainwrapper.
Hey guys, I'm not opposed to putting this in, I just haven't had time. I don't have any experience with carthage at the moment. And yes the current project supports cocoa pods, but its not part of the official cocoa pods repo yet, so you have to use it as a private repo. Thats on the list of things to do as well.
from swiftkeychainwrapper.
I've updated to v1.0.10 on master now which includes a pull request that added Carthage support. I do not use Carthage myself, so if anyone wants to test it out and let me know if it works, that would be much appreciated and then we can close this issue. Else I'll try and find time to look into Carthage more and see how to test it myself.
from swiftkeychainwrapper.
Related Issues (20)
- Module compiled with Swift 5.1.3 cannot be imported by the Swift 5.2 compiler HOT 1
- Error trying to install application
- Clear Data HOT 1
- Deprecation warnings for iOS12 HOT 4
- Accessibility is not working HOT 2
- Problem with set(...) in template
- Access Groups clarification HOT 4
- Support for multi platform framework target(tvOS, iOS, macOS) HOT 1
- Can this pod work with Mac Project Catalyst
- SecItemCopyMatching Crash HOT 1
- iOS15 beta clearing keychain HOT 1
- 'NSKeyedUnarchiveFromData' should not be used
- Callback on keychain value change for given key
- I've noticed, that if i store something and immediately retrieve from other function, it not manage to return appropriate value.
- KeyChain access between app and share extension HOT 1
- XCTestCase: set NewValue return False HOT 2
- Incrementing and saving do not work properly HOT 1
- Apple SignIn email is not retrieving
- removeAllKeys does not delete any items that were saved with synchronizable as true
- Receiving "warning: linking against a dylib which is not safe for use in application extensions"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swiftkeychainwrapper.