GithubHelp home page GithubHelp logo

Comments (5)

lexrus avatar lexrus commented on July 30, 2024 1

@jrendel Thank you for the update. I did test with the following Cartfile:

github "jrendel/SwiftKeychainWrapper"

And run carthage update in the same project folder. After a couple seconds, the SwiftKeychainWrapper.framework built under ./Carthage/Build/iOS/.
Everything works fine apart from the warnings:

/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:129:16: warning: immutable value 'retrievedString' was never used; consider replacing with '_' or removing it
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:192:13: warning: variable 'testInt' was never mutated; consider changing to 'let' constant
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:193:13: warning: variable 'myTestObject' was never mutated; consider changing to 'let' constant
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:208:16: warning: immutable value 'retrievedObject' was never used; consider replacing with '_' or removing it
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:248:16: warning: immutable value 'retrievedData' was never used; consider replacing with '_' or removing it
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:129:16: warning: immutable value 'retrievedString' was never used; consider replacing with '_' or removing it
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:192:13: warning: variable 'testInt' was never mutated; consider changing to 'let' constant
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:193:13: warning: variable 'myTestObject' was never mutated; consider changing to 'let' constant
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:208:16: warning: immutable value 'retrievedObject' was never used; consider replacing with '_' or removing it
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:248:16: warning: immutable value 'retrievedData' was never used; consider replacing with '_' or removing it

I guess you should upgrade to Xcode 7.1 and Swift 2.1.

In addition, a simple instruction in README talking about how to build this lib with Carthage would be nice. Take an example:
https://github.com/alamofire/alamofire

from swiftkeychainwrapper.

kkontus avatar kkontus commented on July 30, 2024 1

Any indications when this warnings might be fixed?

from swiftkeychainwrapper.

albertkim avatar albertkim commented on July 30, 2024

Not on the roadmap yet?

from swiftkeychainwrapper.

jrendel avatar jrendel commented on July 30, 2024

Hey guys, I'm not opposed to putting this in, I just haven't had time. I don't have any experience with carthage at the moment. And yes the current project supports cocoa pods, but its not part of the official cocoa pods repo yet, so you have to use it as a private repo. Thats on the list of things to do as well.

from swiftkeychainwrapper.

jrendel avatar jrendel commented on July 30, 2024

I've updated to v1.0.10 on master now which includes a pull request that added Carthage support. I do not use Carthage myself, so if anyone wants to test it out and let me know if it works, that would be much appreciated and then we can close this issue. Else I'll try and find time to look into Carthage more and see how to test it myself.

from swiftkeychainwrapper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.