GithubHelp home page GithubHelp logo

Comments (8)

jrendel avatar jrendel commented on July 30, 2024

I have not actively been testing on iOS7. Nothing was intentionally removed, but I've been keeping the project up to date with the latest Swift and Xcode releases, so something may have inadvertently been broken. I would have to redownload an Xcode 7 simulator to test it out.

Do you know what is failing to compile?

from swiftkeychainwrapper.

moonvader avatar moonvader commented on July 30, 2024

I receive many warnings if I set Deployment Target to 7.0 with last version of your code.
Xcode suggest to set available tags - maybe you can check it?

from swiftkeychainwrapper.

jrendel avatar jrendel commented on July 30, 2024

I pushed some changes to correct this so it should still properly support iOS 7. Changes are in dev branch.

from swiftkeychainwrapper.

calhouncole avatar calhouncole commented on July 30, 2024

I'm trying to build from the most recent commit in the developer branch. When I have my deployment target set as 7.0 Xcode -- it's saying that the minimum deployment target for SwiftKeychainWrapper is 8.0?

from swiftkeychainwrapper.

jrendel avatar jrendel commented on July 30, 2024

Are you trying to build the keychain project directly? Everything looks like it checks out for me on that build.

Now if you're using cocoa pods to pull down the framework, thats still pulling the master branch version that is set to 8.0 and up. I still need to get things merged into master.

If you're doing something else, let me know and I'll see if I can test the same scenario.

from swiftkeychainwrapper.

jrendel avatar jrendel commented on July 30, 2024

I just realized I don't think dynamic frameworks are supported on iOS 7? Only iOS 8 and up I believe.

from swiftkeychainwrapper.

moonvader avatar moonvader commented on July 30, 2024

I just added Swift file manually in my project and it works fine. What happened that i can't now use it on iOS7?

from swiftkeychainwrapper.

jrendel avatar jrendel commented on July 30, 2024

As a framework I'm only supporting iOS 8 and up, since dynamic frameworks do not work in iOS 7.

It is possible like you said to manually put the files into a project and use them that way. In that case they work with iOS 7 fine except I removed part of the code allowing for this usage without thinking.

KeychainOptions.swift has a check at the end for a value that only exists in iOS 8 and up. I will reverse the code for now to allow the files to be used in iOS 7, however, this generates a warning for the project since I'm putting an availability check for iOS 8 and up when the project's minimum supported version is iOS 8 in the first place. I'm not quite sure what the best solution will be here in regards to the warning, but it will otherwise work fine.

from swiftkeychainwrapper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.