Upload not compatible with generic django storage class about django-formset

[tissieres]

For example I'm using django-minio-storage and their implementation of the Storage class is defined here. I would adapt your implementation to use the file storage API described in the docs instead of relying on Pathlib.

django-formset/formset/upload.py

Lines 109 to 118 in 38d20ca

	# copy uploaded file into temporary clipboard inside the default storage location
	UPLOAD_TEMP_DIR.mkdir(parents=True, exist_ok=True)
	file_path = Path(file_obj.name)
	fh, temp_path = tempfile.mkstemp(suffix=file_path.suffix, prefix=f'{file_path.stem}.', dir=UPLOAD_TEMP_DIR)
	for chunk in file_obj.chunks():
	os.write(fh, chunk)
	os.close(fh)
	assert default_storage.size(temp_path) == file_obj.size
	relative_path = Path(temp_path).relative_to(default_storage.location)
	download_url = default_storage.url(relative_path)

This part could probably simplified by using the File storage API instead of doing these operations by yourself on the filesystem. Your unit test would only use this API as well and it would make your package compatible with any storage implementation. What do you think?

[jrief]

Unfortunately I do not have any configuration using S3. Can you please point me onto some documentation where I can emulate the S3_BOTO behaviour for my unit tests. I don't want to use AWS in my unit tests.

How would you fix that?

[jrief]

Could you please check with HEAD from main branch.

I did not try django-minio-storage or any other storage class. However I now use the proper file storage API. Thanks for reporting.

Would you make the storage class for this file upload configurable, or just keep the current default_storage?

[tissieres]

It's working with django-minio-storage, but I dot not explicitely use the file upload feature so far. That was the import that was failing for me.

I never use multiple storage backends so no need for it to be configurable for me.

Thank you very much for your fast fix 👍