GithubHelp home page GithubHelp logo

Comments (8)

jrvansuita avatar jrvansuita commented on August 24, 2024 2

ok, will be done for the next couple days. If you are rushed, you can create a pull request.

from materialabout.

bhapps avatar bhapps commented on August 24, 2024 1

** See Updates **
Was able to remove Margin on the CardView inside the build(); using below
Was able to remove Margin & padding to have view spread full width on the CardView inside the build(); using below

    public void onCreate(Bundle savedInstanceState) {
       //...
      //...

      try {

    CardView layout = (CardView)findViewById(R.id.card_holder);
    CardView.LayoutParams params = new CardView.LayoutParams(CardView.LayoutParams.MATCH_PARENT, CardView.LayoutParams.WRAP_CONTENT);
    params.setMargins(0,0,0,0);

        //updates
        //remove Shadow
        layout.setCardElevation(0);
        //remove radius
        layout.setRadius(0);
        //remove further padding
        layout.setUseCompatPadding(false);
        layout.setMaxCardElevation(0);
        layout.setPreventCornerOverlap(false);


        layout.setLayoutParams(params);

   }catch(Exception error_about) {

         //show my error in the ui
         //log error via error_about

     }
    //...
    //..

}

Should wrap this in try{//the card view}catch(){//error, hide ui stuff, show error}; just incase the card_holder of other elements are not found/exception ...

from materialabout.

jrvansuita avatar jrvansuita commented on August 24, 2024

Thanks my friend. Feel free to help me with this. Try me a pull request, or give me some time to do it.

from materialabout.

bhapps avatar bhapps commented on August 24, 2024

Thanks for quick response. Will see how I go.
So it does get padding added by default?

Please see main/res/layout/xab_about_layout.xml which has all the padding, margin settings for the libraries I believe

from materialabout.

jrvansuita avatar jrvansuita commented on August 24, 2024

Yes, It should be set by the Builder, but it's not. Today, I have it fixed in the layout xml. We need to bring this configurations to java, and set it programmatically.

from materialabout.

bhapps avatar bhapps commented on August 24, 2024

Yes, It should be set by the Builder, but it's not. Today, I have it fixed in the layout xml. We need to bring this configurations to java, and set it programmatically.

Yes is see this for other .set() - like divider line height etc values done in the java files, which in turn edit the layout xmls as such yeah.

from materialabout.

bhapps avatar bhapps commented on August 24, 2024

no, thats ok, just like to see features added to the library which may make this awesome lib even better.

from materialabout.

jrvansuita avatar jrvansuita commented on August 24, 2024

https://github.com/jrvansuita/MaterialAbout/releases/tag/0.1.2

from materialabout.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.