GithubHelp home page GithubHelp logo

Comments (9)

Yohn avatar Yohn commented on July 21, 2024

I like the idea, I also have something like that in my script that changes the content of the modal, and its then pushed down halfway through the page..
the thing with doing something like that would be it would almost seem jumpy or glitchy kinda when the modal moves or jumps up and down the page when a different "tab" would be clicked

from bootstrap-modal.

lookfirst avatar lookfirst commented on July 21, 2024

Yea, I think the jumpy nature is better than having the modal feel like it is at the bottom of the page. If it can be done with a nice slide effect like the fade.in effect, I don't think it'll be that bad.

from bootstrap-modal.

jschr avatar jschr commented on July 21, 2024

I could potentially provide a reLayout function which would just reset the negative margins based on the height and width of the modal. This would also make the modal animate into it's new position. What I don't think I will be able to do without a lot of work is have the modal also animate to it's new height.

I've also had a similar use case but instead of actually redrawing the contents of a modal I wanted to open a new modal but reuse the same backdrop. So you would see the modal slide up and a new one slide down without having the backdrop fade in/out. I wonder if this behaviour is a little smoother and less jarring for the user? I'll be adding this feature in for 2.1 which is currently in the wip-2.1 branch but I'm not happy with the solution yet.

from bootstrap-modal.

lookfirst avatar lookfirst commented on July 21, 2024

I'm ok with not animating to the new height. I'm also ok with slide up/down. You rock @jschr

from bootstrap-modal.

jschr avatar jschr commented on July 21, 2024

Preliminary work is in the 2.1 branch. You'll notice there's a layout function in the modal class that you can use to reposition the modal at any time. Also added the ability to watch for window resize from the modalmanager. Right now that's opt-in because I'm concerned about potential performance issues when resizing but at least it's there.

from bootstrap-modal.

jschr avatar jschr commented on July 21, 2024

closing as this functionality is now in 2,1

from bootstrap-modal.

Yohn avatar Yohn commented on July 21, 2024

awesome! thanks @jschr
you got an example of how to use the repositioning of the modals?
I was trying $.fn.modal.layout(), $('.modal').layout() and a few others but that wasnt doing the trick for me

from bootstrap-modal.

jschr avatar jschr commented on July 21, 2024

You call it just like the other modal functions such as hide/show i.e. $('.modal').modal('layout').

Hope that helps.

from bootstrap-modal.

Yohn avatar Yohn commented on July 21, 2024

lol I shoulda figured that one out.. works great! Thanks for your work on improving the modals man!

from bootstrap-modal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.