GithubHelp home page GithubHelp logo

Comments (4)

jschr avatar jschr commented on July 21, 2024

Is it a requirement that your dynamic modals be attached to body when created? The ModalManager will automatically remove dynamically created modals (if the modal does not have a parent element).

from bootstrap-modal.

rubenvdb avatar rubenvdb commented on July 21, 2024

Not attaching them to the body seems to work, thanks!

from bootstrap-modal.

jschr avatar jschr commented on July 21, 2024

No problem.

In case you were wondering why this is happening, one main difference with my modals vs bootstrap's modal is that to solve a few issues I move the modal's around when they are opened by appending to a modal-scrollable element. Once the modal is closed, I attempt to return it back to it's original state before it was modaled, which means appending it back to it's original parent. In this case, you had a parent of 'body' and I believe your remove() would run first and then it would be appended back to the body after.

Hope that helps.

from bootstrap-modal.

bentleyo avatar bentleyo commented on July 21, 2024

I've noticed that one issue with this that if the modal isn't appended to the body first that any JS inside the modal will be called before the elements have been added to the DOM. Is there a way to easily get around this? (beside removing inline JS from modal content)

Sorry for commenting on an old issue I just thought it wasn't worth creating a new one.

from bootstrap-modal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.