Events clashing about bootstrap-modal

[adam-lynch]

Also, I cannot change .trigger('hidden') to .trigger('hidden.modal') in bootstrap-modal.js:207; the backdrop is no longer removed. I cannot find anywhere where hidden is subscribed to and the backdrop is then removed.

[jschr]

If you namespace the events with event.namespace it will break everywhere that is just listening for the event. You will need to namespace all the listeners as well. The ModalManager class is where the show/hidden events are subscribed to.

I believe this line bootstrap-modalmanager.js:64 would have to be something like .on('show.modal.modalmanager') and the same goes for every other namespaced event.

I'm curious as I am also using the datepicker in my project and have had no issues, what event clashing are you experiencing?

Bootstrap will be namespacing all their events in an upcoming release so I plan to do the same when it is.

[jschr]

Ah, if you have other components inside the modal which fire hide/show events you will see your event subscriptions on the modal being fired for them as well. This is why I'm anxiously waiting for them to namespace events.

I put in a work around to make sure that the ModalManager class to make sure it would only fire the subscription if the modal was the one who fired it (see bootstrap-modalmanager.js:376). If I didn't do this, tabs within modals would cause the modalmanager to fire when you click a tab.

As for the focus issue, not sure if it's related or not but if you're able to create a jsfiddle demonstrating it I'd be glad to take a look.

[adam-lynch]

Ah ok.

#60; the issue my colleage has logged about the focus being lost in the modal.

[adam-lynch]

@jschr Shit, I accidentally deleted my comment between your last two. Have you still got it in your emails or anything?

[jschr]

Ah ok.

Well, I was working with the modal's hide event, cleaning up some stuff. At one stage I noticed some unexpected behaviour so I just stuck in an alert() to be fired whenver the event was triggered, and it was being triggered way too much. It almost seemed like it was on every click.

Side note: We did also have a focus problem in the modal though, where complete() seemed to be called on the first click of the modal, not when the transition ended (see bootstrap-modalmanager.js:96). Therefore, if you clicked a field for example, it would gain but then lose focus. I'll get my colleague to log an issue on it (and I'll link it here) because he was the one actually troubleshooting it. It could be related, but I did still had the problem when I namespaced all the events in bootstrap-datepicker and this project, minus show.

Cool, I can do it when I've time if you like since I want to contribute anyway, and it can be merged in when Bootstrap namespaces theirs.>

[adam-lynch]

I don't know how to properly link an existing pull request to an existing issue so here's the pull request related to this issue.

[jschr]

Closing for now as we now have a pull request but will wait for bootstrap to release their fix before merging.

[barmstrong]

Is there a work around for this in the mean time? After adding bootstrap-modal we are no longer receiving shown events (probably others) on modals, so this sort of code no longer works:

$(document).on 'shown', '.modal', ()->
  $(this).find('.focus').focus()

I assume this is a related issue, but let me know if not. Thanks!

[barmstrong]

Hmm, surprisingly...this works though:

$('.modal').on 'shown', ->
  $(this).find('.focus').focus()

It has different functionality, so we really want to use the previous version - any idea why the snippet in my previous comment would have stopped working but this one works? Thanks!

[jschr]

I think this is because I am using triggerHandler instead of trigger to fire the events. This is something that I need to change. It was a poor solution to solve some of the event namespacing issues that has been around since the first version. In the meantime you can make this change yourself in both the ModalManager and Modal classes to fix it. I will be pushing a fix for this as soon as I get some time.

[barmstrong]

Thanks @jschr that worked perfectly actually (just did a global find/replace of triggerHandler to trigger). Seems like a pretty simple fix - shall I send a pull request?

[jschr]

Ya sure that would be appreciated.

Thanks

[barmstrong]

Done!
#69

On Fri, Feb 8, 2013 at 5:22 AM, Jordan Schroter [email protected]:

Ya sure that would be appreciated.

Thanks

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/57#issuecomment-13289922.