checkReturnTypes fails with TypeError: Cannot call method 'replace' of undefined about jscs-jsdoc

[pigulla]

This also occurs if checkReturnTypes is set to false. Shouldn't that disable the rule completely?

[qfox]

The problem here is jsdoc parsing and traversing ast tree. Basically it was made very-very hacky and this wasn't refactored as well. So yes, you're right about it.

p.s. Except one thing: It's a plugin based on jscs so values in parameters means, even false values. To disable we should use null (as well as jscs do).

[qfox]

@pigulla Oops. Can you tell me what version of jscs you using here? Can't repeat this ;-(

upd: But yeah. It shouldn't occurs on something: false. It should throw an error on configuration loading. I've created #23 for this

[pigulla]

I was using 1.7.3 - thanks for looking into this.

[qfox]

But what about error? I'm using jscs 1.7.3 with jscs-jsdoc 0.0.15.

[pigulla]

Try this gist: https://gist.github.com/pigulla/904685704509b6e4462c

When I clone this, do an npm install and then run node_modules/jscs/bin/jscs test.js I get the error you can see in my first post. It's really odd that you can't seem to reproduce this.

[qfox]

@pigulla What's environment you have? I'm testing on debian, maybe reason of crashing in OS?

[pigulla]

I'm using an older version of Linux Mint:

pigullar@vm-dev ~ $ cat /etc/issue
Linux Mint 16 Petra \n \l
pigullar@vm-dev ~ $ cat /proc/version
Linux version 3.11.0-12-generic (buildd@allspice) (gcc version 4.8.1 (Ubuntu/Linaro 4.8.1-10ubuntu7) ) #19-Ubuntu SMP Wed Oct 9 16:20:46 UTC 2013

I'll run the gist against an up-to-date Mint later today to see if the problem occurs there as well. (Although it really doesn't look like an OS-dependent issue to me, but stranger things have happened...)

[qfox]

@pigulla Thanks again. I've got this!

[qfox]

Fixed in v0.0.16, anyway we need to add more tests for column calculating. Console error reporter crashes on getting "1[object Object]" string instead of valid number.