Comments (3)
I've been following this project for a a while. How many requests do you expect the bot will be making against the GitHub API to do this? According to the GitHub API
"For requests using Basic Authentication or OAuth, you can make up to 5,000 requests per hour. For unauthenticated requests, the rate limit allows you to make up to 60 requests per hour. Unauthenticated requests are associated with your IP address, and not the user making requests."
I haven't delved deep into the code yet but unless unless you're merging 20-30 PRs a day (non authenticated requests) I don't see how you'd exceed the rate limit.
from bot.
There are a couple things to consider:
- The bot can perform multiple requests per pull request (based on the number of commits, comments, and files). These resources are paginated so we have to perform n/page size requests for each pull request. We then read several files (1 request each)
- We revalidate pull requests whenever a new commit is added
- we preform multiple other requests per validation (refresh repo state, get issue, check if user is collab, set pr status (twice), couple other things
- We preform some meta checks if info.ini lists a github repository (we check repo exists and look at its tagged released)
This can end up taking a large number of requests on some pull requests.
We also share are oauth login with libgrabber which eats a ton of our request quota; this can obviously be addressed by creating a new github account for bot.
Anyway all that said, we haven't hit the quota often but it can happen; adding a step which checks multiple prs on an interval could be suspect in our current configuration
from bot.
Mostly fixed in f96af09 though this still requires a bit more tuning
from bot.
Related Issues (20)
- Unable to update package because of case sensitivity? HOT 1
- Bot failes very often HOT 7
- Bot failing with SSL error HOT 1
- UTF-8 encoded files seems be interpreted as binary HOT 12
- Failed to warn about deleted files HOT 2
- Merge a pull request with squash option HOT 3
- Delete branch whenever a pull request is closed/merged
- Setup jsdelvr-bot for testing proposes on Heroku? HOT 4
- info.ini error where info.ini is present (again) HOT 2
- .html (on theme/github.html) seems odd to want to host
- info.ini error where info.ini is present (once again)
- Folder structure changes reported incorrectly HOT 2
- Add an option to request re-check HOT 4
- Allow non-lowercase chars HOT 1
- bot says files have been modified HOT 1
- bot is not happy with minification
- Can't write the author's name properly due to non-ascii characters rule
- How to retain subdir within basePath
- Structure check way to strict HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bot.