Comments (8)
What exactly do you mean by 'rename' please?
For the pixijs issue, that is a bug on their end, not ours, & they need to fix it.
The minified file is PROJECTNAME.js & the 'source' is PROJECTNAME.dev.js which is great; that how I personally prefer it. But the sourcemap will never be found when pixi.js
is used, since the client will look for pixi.js.map
the way my research points to. It is their Gruntfile.js that fails to name the sourcemap correctly.
I think we has similar conversations with other bugs, like security holes etc.
If you think we can fix it on our end, that's cool. Could even add extra code to figure out if there is a sourcemap to rename it, but what to do if there are multiple minfied files & sourcmaps? Might be better at most just to flag as an issue (bot?), & await human interaction, don't you think?
from libgrabber.
The problem that I was hoping to solve here was not the .map issue.
basically pixi.js -> pixi.min.js.
This functionality could help us keep existing structure and auto-update projects at the same time.
Every time we change something in the structure its a potential problem. So I want to avoid this as much as possible.
from libgrabber.
I thought we tried to cover this scenario with the per-version mainfile
or 'alt-mainfile` months ago?
from libgrabber.
Sure, but in my opinion it doesn't make sense to change file structure outside of major.minor versions. Allowing mapping would allow us to enforce that rule until the next minor/major version is released when we can update the file structure
from libgrabber.
@tomByrer Outside of mainfiles structure changes are still dangerous. For example for people using version aliasing. They would get upgraded to the new version automatically but if the file is no longer available they will get a 404
@megawac I agree
from libgrabber.
doesn't make sense to change file structure outside of major.minor versions
In an ideal world, everyone would SemVer the exact same way. Reality is people are going to do what they do, which may break stuff. Are we going to enforce proper SemVer on everyone in every PR? (Which is a solution, but will require visually checking every version-changes.)
Would file aliasing be a good idea when the file structure changes?
I'm starting to lean towards removing the mainfile
in the top-level info.ini
totally to force people to reconsider what their mainfile should be per release, & make them enter it in every version.ini
if there is more than one file.
from libgrabber.
mainfile
is not a problem for now. Our solution of mainfile per version works just fine.
Like I said what worries me is version aliasing and structure changes. This is why rename files by bot would help a lot
from libgrabber.
OK, now I understand why you'd like to have this @jimaek; to prevent aliasing.
Yes, having project.js
to be a clone of project.min.js
would be helpful to work around the mistake of uploading non-minified files. Reopen please?
from libgrabber.
Related Issues (20)
- Allow the bot to merge own PRs HOT 3
- Faster updates with Webhooks HOT 2
- Does libgrabber need to run locally? HOT 4
- Are all files read for SemVer? HOT 6
- sub-subfolders listing HOT 3
- Use NMM & bower instead of GitHub "Release"? HOT 7
- Support major.minor versions HOT 13
- name field is jsDelvr's folder? HOT 1
- Ignore beta/alpha versions HOT 7
- Version aliasing doesn't point to the latest version HOT 7
- Don't upload a folder with too many files (eg 100s of icons) HOT 4
- Change the tag grabbing url to grab more tags HOT 11
- releases/tag/0.3.1 but not uploaded? HOT 1
- Does libgrabber verify if files are new? HOT 3
- Send an email when an update fails HOT 2
- Add support for indexs and ftp HOT 14
- Support syncing multiple major versions HOT 3
- Add support for github releases HOT 2
- Follow redirects
- Deprications and warnings
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libgrabber.