GithubHelp home page GithubHelp logo

Comments (9)

jimaek avatar jimaek commented on June 3, 2024

Too spammy. How about opening an Issue in this same repo or in jsdelivr/jsdelivr and mentioning the author? This way he gets a notifications and will come and check out the issue.

Which will contain info about jsDelivr and that his project is now auto-updated.

from libgrabber.

tomByrer avatar tomByrer commented on June 3, 2024

Too spammy.

Sorry, I didn't explain well. I was thinking of doing this ONLY the first time libgrabber is ran. That's why if "CDN" or "jsDelivr" is in the README already, then no PR is made. The README PR is only a service to help add instructions, like I do in real life.
Or do you think that is too spammy also? (I understand if you do)

How about opening an Issue in this same repo or in jsdelivr/jsdelivr and mentioning the author?

Neat idea... maybe as an option in the Update.json; "update notification": "none"(default)|"issue me"|"issue jsdelivr"|"email"|"twitter"?

from libgrabber.

jimaek avatar jimaek commented on June 3, 2024

Yeah, I was talking about the first time as well. The first time notify the author by mentioning them in an issue. Most authors wont appreciate an automated PR.

The update notification option is interesting. @aleksandara What do you think?

from libgrabber.

tomByrer avatar tomByrer commented on June 3, 2024

Most authors won't appreciate an automated PR.

Understandably. I guess README instructions will have to be an educational issue then.

I'm starting to warm up to an opt-in Twitter notification. Could add a link to the jsDeliver.com/!#PROJECT slug in the post. & if we could get their "changes" URL (usually CHANGELOG.*, or README.md#changes, then it would be a service for them; they get some automated public relations/social SEO as well.

from libgrabber.

jimaek avatar jimaek commented on June 3, 2024

The problem is the rate-limiting by Twitter. No more than a few tweets can go out in a day. And if we wait 1-2 days to notify the author then the point of the notification is lost.

from libgrabber.

aleksandara avatar aleksandara commented on June 3, 2024

I like the idea of notifying developer when an update is done, at least for the first time. When the developer's username is mentioned in the PR libgrabber creates, we can then display in the PR information to do a quick check for a missing file, how to change update.json, provide some links, etc.

Maybe we add additonally an option in update.json to choose when to send an update. E.g. always, major (when major part of version changes), minor, etc.

Btw, in "update notification" option, what is the difference between issue me and issue jsdelivr?

from libgrabber.

jimaek avatar jimaek commented on June 3, 2024

Yeah, for now we can mention the author in the PR the bot opens. I forgot about that completely.
I think its the most optimal solution.

from libgrabber.

tomByrer avatar tomByrer commented on June 3, 2024

issue me = post an issue to the repo's issue tracker; best for "Please update your README & let your twitter followers know" reminder.
issue jsdelivr = @author inside jsdelivr's PR; exactly jimaek's idea; best for gentle poking

I like the prompt for fixing libgrabber issues.

rate-limiting by Twitter. No more than a few tweets can go out in a day

Sure about that? Seems to be a bit more, & I assume only a fraction will turn on Tweet notifications. I Twit only 1/week, so never hit it ;) Could just use it for new projects at first to test out.

from libgrabber.

jimaek avatar jimaek commented on June 3, 2024

@aleksandara Currently if enable the author notification does it notify him only once or on every update?

from libgrabber.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.