Comments (9)
Too spammy. How about opening an Issue in this same repo or in jsdelivr/jsdelivr and mentioning the author? This way he gets a notifications and will come and check out the issue.
Which will contain info about jsDelivr and that his project is now auto-updated.
from libgrabber.
Too spammy.
Sorry, I didn't explain well. I was thinking of doing this ONLY the first time libgrabber is ran. That's why if "CDN" or "jsDelivr" is in the README already, then no PR is made. The README PR is only a service to help add instructions, like I do in real life.
Or do you think that is too spammy also? (I understand if you do)
How about opening an Issue in this same repo or in jsdelivr/jsdelivr and mentioning the author?
Neat idea... maybe as an option in the Update.json
; "update notification": "none"(default)|"issue me"|"issue jsdelivr"|"email"|"twitter"
?
from libgrabber.
Yeah, I was talking about the first time as well. The first time notify the author by mentioning them in an issue. Most authors wont appreciate an automated PR.
The update notification option is interesting. @aleksandara What do you think?
from libgrabber.
Most authors won't appreciate an automated PR.
Understandably. I guess README instructions will have to be an educational issue then.
I'm starting to warm up to an opt-in Twitter notification. Could add a link to the jsDeliver.com/!#PROJECT
slug in the post. & if we could get their "changes" URL (usually CHANGELOG.*
, or README.md#changes
, then it would be a service for them; they get some automated public relations/social SEO as well.
from libgrabber.
The problem is the rate-limiting by Twitter. No more than a few tweets can go out in a day. And if we wait 1-2 days to notify the author then the point of the notification is lost.
from libgrabber.
I like the idea of notifying developer when an update is done, at least for the first time. When the developer's username is mentioned in the PR libgrabber creates, we can then display in the PR information to do a quick check for a missing file, how to change update.json
, provide some links, etc.
Maybe we add additonally an option in update.json
to choose when to send an update. E.g. always
, major
(when major part of version changes), minor
, etc.
Btw, in "update notification" option, what is the difference between issue me
and issue jsdelivr
?
from libgrabber.
Yeah, for now we can mention the author in the PR the bot opens. I forgot about that completely.
I think its the most optimal solution.
from libgrabber.
issue me
= post an issue to the repo's issue tracker; best for "Please update your README & let your twitter followers know" reminder.
issue jsdelivr
= @author inside jsdelivr's PR; exactly jimaek's idea; best for gentle poking
I like the prompt for fixing libgrabber issues.
rate-limiting by Twitter. No more than a few tweets can go out in a day
Sure about that? Seems to be a bit more, & I assume only a fraction will turn on Tweet notifications. I Twit only 1/week, so never hit it ;) Could just use it for new projects at first to test out.
from libgrabber.
@aleksandara Currently if enable the author notification does it notify him only once or on every update?
from libgrabber.
Related Issues (20)
- Allow the bot to merge own PRs HOT 3
- Faster updates with Webhooks HOT 2
- Does libgrabber need to run locally? HOT 4
- Are all files read for SemVer? HOT 6
- sub-subfolders listing HOT 3
- Use NMM & bower instead of GitHub "Release"? HOT 7
- Support major.minor versions HOT 13
- name field is jsDelvr's folder? HOT 1
- Ignore beta/alpha versions HOT 7
- Version aliasing doesn't point to the latest version HOT 7
- Don't upload a folder with too many files (eg 100s of icons) HOT 4
- Change the tag grabbing url to grab more tags HOT 11
- releases/tag/0.3.1 but not uploaded? HOT 1
- Does libgrabber verify if files are new? HOT 3
- Send an email when an update fails HOT 2
- Add support for indexs and ftp HOT 14
- Support syncing multiple major versions HOT 3
- Add support for github releases HOT 2
- Follow redirects
- Deprications and warnings
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libgrabber.