Add TOOL_NODE_FLAGS setting about meteor-launchpad

[jshimko]

@kachizukanne What version of Docker are you running? ARG wasn't added until somewhere around v1.9.x. That's the exact error I've seen when running Docker 1.8, so I'm assuming that's likely to be your issue.

[kachizukanne]

Spot on, upgrading docker to a post 1.8 version fixed this

[jshimko]

Sounds reasonable. Have you confirmed that adding that fixes the problem for you? I see several people in that issue saying it didn't work for them.

[krismeister]

# in base.dockerfile
ENV TOOL_NODE_FLAGS=--max-old-space-size=2048

Did work for me - I assume increasing even further or adding garbage collection flags could help others.

[jshimko]

Ok, v1.2.0 has added the option to use Docker's --build-arg flag to set that environment variable. You can now set that to anything you want at build time like this:

docker build --build-arg TOOL_NODE_FLAGS="--max-old-space-size=2048" -t myorg/myapp:latest .

Let me know if that does the trick for you.

[kachizukanne]

This fix seems to break builds that aren't currently using this flag

Please have a look to check if this experience is consistent across board

[jshimko]

I'm going to assume this is working for everyone and close this issue. Feel free to reopen if there's an issue related to these changes.

Also, note the new build arg options that were just added in v1.3.0

https://github.com/jshimko/meteor-launchpad#build-options

[cjim8889]

The issue remains