Comments (5)
@jshimko Thanks for the response. What I meant was actually use the Dockerfile ARG, similar to ENV, which allows variables to be used at build runtime. https://docs.docker.com/engine/reference/builder/#/arg
BTW: can I get you input here: https://forums.meteor.com/t/docker-team-up-to-create-a-reference-docker-image-for-meteor/30829
I personally would like to see your implementation be the MDG recommended version.
from meteor-launchpad.
Well, I did this for several reasons - some preference, some technical limitation. First of all, I feel like it wouldn't be a great developer experience to have to declare arguments in your docker build
command to add dependencies that you want every time (which could easily be the case for something like PhantomJS), so I wanted a way to define those options that would allow you to avoid that and that you can check into source control. I originally wanted to have them as ENV
declarations in your app's Dockerfile, but the ONBUILD
scripts that run those installs happen before the rest of your app Dockerfile is evaluated. So the only option left (other than something in the build command like you suggested) was to add a config file that gets added with your app code.
from meteor-launchpad.
Thanks @keyscores. I'll take a closer look later today.
from meteor-launchpad.
Thanks for this repository, it's great, I know nothing about meteor but this has helped a lot to learn the build process and it just works! 🌟
I also agree with @keyscores , personally I find adding a .conf
file means learning yet another convention. I've made a pull request that should make this possible, any thoughts?
Ref PR 9
from meteor-launchpad.
Most of the environment variable options that were available have now been given --build-arg
flags. See the new build options docs...
https://github.com/jshimko/meteor-launchpad#build-options
For those that prefer it, the launchpad.conf will still work, but now you can also use the --build-arg flag when building your image.
docker build --build-arg INSTALL_MONGO=true -t myorg/myapp:latest .
from meteor-launchpad.
Related Issues (20)
- Oracle jdbc driver HOT 2
- yarn: command not found HOT 4
- Adding settings.json to .dockerignore? HOT 2
- can't find entrypoint.sh HOT 2
- Hot code push to browser
- Failed to build container due to removal of Wheezy and Jessie from mirrors HOT 1
- Build failed - 404 HOT 1
- Meteor installation fails on Windows
- New Debian Release HOT 1
- 'p80.pool.sks-keyservers.net: Host not found' HOT 4
- Should Gosu vesrion be configurable
- Docker build fails when installing gosu
- E: The repository 'http://security.debian.org/debian-security stable/updates Release' does not have a Release file. HOT 3
- Redirect to https localhost
- E: Unable to locate package libarchive-tools HOT 4
- Meteor requires Node v14.0.0 or later. HOT 2
- docker build fails - HOT 4
- Package 'python' has no installation candidate HOT 1
- E: Package 'python' has no installation candidate HOT 1
- I forked this repo and made possible Meteor 3 deployment. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from meteor-launchpad.